Reworked the generated RegisterAll extension#1199
Open
Umoxfo wants to merge 1 commit into
Open
Conversation
... to ensure it is AOT-safe 1. `IMessengerRegisterAllGenerator.Execute.cs` * Change the IMessenger RegisterAll source-generation to emit public extension methods in the `CommunityToolkit.Mvvm.Messaging` namespace (`RegisterAll(this IMessenger, TRecipient)` and `RegisterAll<TToken>(this IMessenger, TRecipient, TToken)`) instead of producing factory delegates in an `CommunityToolkit.Mvvm.Messaging.__Internals` namespace. * Enable nullable instead of null check. * Update comments. 2. `IMessengerExtensions` class * Simplify the runtime fallback/reflection path. * Update `RequiresDynamicCode`/`RequiresUnreferencedCode` annotetion message and reference URLs. * Update documentation comments. 3. `ObservableRecipient` class * Update `RequiresDynamicCode`/`RequiresUnreferencedCode` annotetion message and reference URLs. * Update documentation comments. 4. Unit Tests * Add new generator test, update expectations, and call sites.
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to ensure it is AOT-safe
IMessengerRegisterAllGenerator.Execute.csCommunityToolkit.Mvvm.Messagingnamespace (RegisterAll(this IMessenger, TRecipient)andRegisterAll<TToken>(this IMessenger, TRecipient, TToken)) instead of producing factory delegates in anCommunityToolkit.Mvvm.Messaging.__Internalsnamespace.IMessengerExtensionsclassRequiresDynamicCode/RequiresUnreferencedCodeannotetion message and reference URLs.ObservableRecipientclassRequiresDynamicCode/RequiresUnreferencedCodeannotetion message and reference URLs.Closes #1123
PR Checklist
Other information