Skip to content

RichEditBoxFormatter addition for ColorCode.UWP#2

Closed
WilliamABradley wants to merge 1 commit intomainfrom
RichEditBoxFormatter
Closed

RichEditBoxFormatter addition for ColorCode.UWP#2
WilliamABradley wants to merge 1 commit intomainfrom
RichEditBoxFormatter

Conversation

@WilliamABradley
Copy link
Contributor

-Built most of the Formatter for RichEditBox.

-Removed Write abstract requirement on CodeColorizerBase.

-Modified Test/Sample app with navigation and RichEditBox sample.

A few issues with rendering remain that need to be fixed.

-Removed Write abstract requirement on CodeColorizerBase.

-Modified Test/Sample app with navigation and RichEditBox sample.
@WilliamABradley WilliamABradley self-assigned this Feb 17, 2018
/// <param name="deepscan"></param>
/// <param name="includeCommandBars"></param>
/// <returns></returns>
public static T FirstChildofType<T>(DependencyObject parent, bool deepscan = false, bool includeCommandBars = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like just a combo of the LogicalTree Helpers and the VisualTree Helpers already in the toolkit, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't see any in the toolkit? Point me?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// <summary>
/// Creates a <see cref="RichTextBlockFormatter"/>, for rendering Syntax Highlighted code to a RichTextBlock.
/// </summary>
public class RichEditBoxFormatter : CodeColorizerBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this could this be an extension with an attached property instead of a helper class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be both, I would like to keep the formatter class style, as that is what the other Formatters are.

I haven't played with extensions before, but I'll look into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I set a Markup Extension for a specific control only, is there some documentation on creating UI Extensions for more info than I can garner from the ones in the Toolkit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just change the type in the Get/SetValue from DependencyProperty to the specific control to limit it (like they did in TextBoxRegEx). Is that what you're asking?

@azchohfi azchohfi force-pushed the master branch 10 times, most recently from 3b92274 to f3e6bd1 Compare November 17, 2021 20:36
@michael-hawker michael-hawker added this to the 8.0.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants