RichEditBoxFormatter addition for ColorCode.UWP#2
RichEditBoxFormatter addition for ColorCode.UWP#2WilliamABradley wants to merge 1 commit intomainfrom
Conversation
-Removed Write abstract requirement on CodeColorizerBase. -Modified Test/Sample app with navigation and RichEditBox sample.
| /// <param name="deepscan"></param> | ||
| /// <param name="includeCommandBars"></param> | ||
| /// <returns></returns> | ||
| public static T FirstChildofType<T>(DependencyObject parent, bool deepscan = false, bool includeCommandBars = false) |
There was a problem hiding this comment.
This looks like just a combo of the LogicalTree Helpers and the VisualTree Helpers already in the toolkit, no?
There was a problem hiding this comment.
I couldn't see any in the toolkit? Point me?
There was a problem hiding this comment.
| /// <summary> | ||
| /// Creates a <see cref="RichTextBlockFormatter"/>, for rendering Syntax Highlighted code to a RichTextBlock. | ||
| /// </summary> | ||
| public class RichEditBoxFormatter : CodeColorizerBase |
There was a problem hiding this comment.
Seems like this could this be an extension with an attached property instead of a helper class?
There was a problem hiding this comment.
It could be both, I would like to keep the formatter class style, as that is what the other Formatters are.
I haven't played with extensions before, but I'll look into it.
There was a problem hiding this comment.
How would I set a Markup Extension for a specific control only, is there some documentation on creating UI Extensions for more info than I can garner from the ones in the Toolkit?
There was a problem hiding this comment.
You just change the type in the Get/SetValue from DependencyProperty to the specific control to limit it (like they did in TextBoxRegEx). Is that what you're asking?
3b92274 to
f3e6bd1
Compare
-Built most of the Formatter for RichEditBox.
-Removed Write abstract requirement on CodeColorizerBase.
-Modified Test/Sample app with navigation and RichEditBox sample.
A few issues with rendering remain that need to be fixed.