chore: harden progression automation and recovery tooling#212
Conversation
Learning Room Validation ReportGreat work. Your changes look good. Resources |
|
Hi! I am Gandalf, your workshop agent. I bring a little magic to make this interaction clear, helpful, and fun. Here is my review of your pull request: Report StatusValidation Needs Attention [ACTION REQUIRED] Required Checks
Learning ResourcesBased on your changes, these guides might help: Automated validation by Learning Room Bot. Gandalf generated this review. Last updated: 2026-05-18T00:59:22.270Z |
github-actions
Bot
added
documentation
Peer Review AssignedHi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review. For @taylorarndt:This is a great opportunity to practice code review skills! Here's what to look for: Content Quality:
Accessibility:
Documentation:
Review Guidelines:
Resources: Pairing by Learning Room Grouping Engine |
There was a problem hiding this comment.
Pull request overview
Hardens the classroom skills-progression automation by adding a create-event-driven first-issue bootstrap, syncs the qa-bundle copy of the workflow, extends the template smoke test to validate the new trigger/job and detect the auto-created issue, removes accidentally duplicated content from Seed-LearningRoomChallenge.ps1, fixes a broken git add invocation in the restore script, and introduces a new bulk classroom-sync script for remediating student repos at scale.
Changes:
- Add
createtrigger and idempotentcreate-first-issuejob to both the live and qa-bundleskills-progression.yml. - Extend
Test-LearningRoomTemplate.ps1with helpers to read repo file content and wait for the auto-created first issue, plus regex assertions on the workflow. - Add
Sync-StudentLearningRoomRepos.ps1and adjustRestore-LearningRoomFiles.ps1(trimcore-day2set, fix array splat forgit add); deduplicateSeed-LearningRoomChallenge.ps1.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| learning-room/.github/workflows/skills-progression.yml | Adds create trigger and first-issue bootstrap job. |
| admin/qa-bundle/learning-room/.github/workflows/skills-progression.yml | Mirrors the workflow change in the qa bundle. |
| scripts/classroom/Test-LearningRoomTemplate.ps1 | Adds helpers and assertions to validate the new trigger and auto-created issue. |
| scripts/classroom/Sync-StudentLearningRoomRepos.ps1 | New bulk sync script for student repos with activity guard and optional auto-merge. |
| scripts/classroom/Restore-LearningRoomFiles.ps1 | Drops peer-review-practice.md from core-day2; fixes git add argument splatting. |
| scripts/classroom/Seed-LearningRoomChallenge.ps1 | Removes duplicated script body. |
| create: | ||
| types: [repository] |
| create: | ||
| types: [repository] |
| [string]$TemplateRef = 'main', | ||
|
|
||
| [ValidateSet('core-day1', 'core-day2', 'automation-core', 'all-core', 'custom')] | ||
| [string]$Profile = 'all-core', |
Progress UpdateGreat work, @accesswatch! Current Level: Explorer Available Challenges:
Keep going! |
Summary\n- harden skills progression workflow with create-event gating and idempotent first-issue creation\n- sync qa-bundle learning-room workflow with production workflow behavior\n- expand template smoke test to validate create trigger and first-issue bootstrapping\n- include classroom recovery/sync script updates for dependable repo remediation at scale\n\n## Validation\n- PowerShell parser syntax checks passed for modified scripts\n- live disposable repo verification already confirmed challenge progression behavior on issue close\n- smoke test now fails fast when template is missing required create trigger (expected until template sync PR is merged)