Refactor nodes into modular package and add new test assertions#2
Open
WASasquatch wants to merge 2 commits intomainfrom
Open
Refactor nodes into modular package and add new test assertions#2WASasquatch wants to merge 2 commits intomainfrom
WASasquatch wants to merge 2 commits intomainfrom
Conversation
Split monolithic nodes.py into nodes/ package with separate modules for general assertions, image assertions, mask assertions, string assertions, generators, and test definition. Add auto-discovery of node classes via pkgutil. Add new assertion nodes (image similarity, mask coverage/binary/fuzzy, string contains/match/hash), new generators (mask, string), and a MaskCheckerboardTest workflow.
Author
|
Claude seems to have taken the liberty to add a test workflow. That hasn't been reviewed, and was not asked for. Intention of using claude was to just do the PR in same style as other projects cloned and follow same formatting without me having to go look at them myself. |
AssertStringNotContains supports literal, regex, and llm_guard modes for checking that strings don't contain forbidden patterns. AssertStringLength validates string length is within min/max bounds, useful for non-deterministic LLM outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodes.pyinto anodes/package with separate modules:assertions_general,assertions_image,assertions_mask,assertions_string,generators,test_definition__init__.pyto auto-discover node classes viapkgutilinstead of manual importsMaskCheckerboardTest.jsontest workflowAll new and existing nodes have been tested and confirmed working.