fix: correct order total currency formatting in notification email#5
Open
devin-ai-integration[bot] wants to merge 1 commit intoworkshop-260317from
Open
Conversation
The FormatCurrency method in NotificationRenderer was incorrectly dividing the amount by 100, treating OrderPlacedEvent.TotalAmount as cents. The shared contract defines TotalAmount as decimal (dollars), so the division caused a $149.99 order to display as $1.50. Also fix incorrect relative path for Shared project references in Notification.API.csproj (..\..\Shared -> ..\..\..\Shared).
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where order confirmation emails showed the wrong total amount (e.g. $149.99 displayed as $1.50).
Root cause:
NotificationRenderer.FormatCurrencywas dividingamountby100m, treatingOrderPlacedEvent.TotalAmountas an integer cent value. The shared contract definesTotalAmountasdecimal(already in dollars), so the division was wrong.Also fixes a pre-existing broken project reference path in
Notification.API.csproj— theShared.ContractsandShared.Infrastructurereferences pointed one directory level too shallow (..\..\Shared\instead of..\..\..\Shared\), preventing the service from building standalone.Before / After:
Review & Testing Checklist for Human
OrderPlacedEvent.TotalAmount(Shared.Contracts/Events/OrderPlacedEvent.cs) is indeeddecimaldollars and not cents — this is the core assumption of the fix.Identity.API,Customer.API, andProduct.APIhave the same..\..\Shared\pattern and likely also fail to build standalone. This PR only fixesNotification.API./api/notification/events/order-placedwith"totalAmount": 149.99and verify the/previewendpoint shows$149.99.FormatCurrency/RenderOrderConfirmationto prevent regression.Notes
/ 100mlogic had a misleading comment claiming the event uses a cents representation — this was incorrect and has been removed.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/692db2194ad14a0f9d04d1a6c82b280c
Requested by: @bsmitches