fix(commands): skip Web Site projects when cleaning#32
Merged
Conversation
For legacy Web Site Projects (project type GUID
{E24C65DC-7377-472B-9ABA-BC803B73C61A}) the bin folder is not a build
output; it contains assemblies that are integral to the project. Detect
these via Project.IsKindAsync(ProjectTypes.WEBSITE) and skip them.
Show a single summary MessageBox after a solution-level Super Clean listing any skipped Web Site projects, and a dedicated MessageBox when Super Clean is invoked directly on a Web Site project so the user understands why nothing was cleaned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{E24C65DC-7377-472B-9ABA-BC803B73C61A}) viaProject.IsKindAsync(ProjectTypes.WEBSITE)and skip them — theirbinfolder holds integral runtime assemblies, not build output.Test plan
bin/objare cleared, the website'sbinis untouched, and a summary MessageBox lists the website by name.binis untouched and a MessageBox names the skipped project.Resolves #31