Skip to content

Prevent cross site scripting #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
girishpanchal30 wants to merge 2 commits into
base: development
Choose a base branch
from
+27 −9
Open

Prevent cross site scripting #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a2826e
fix: prevent cross site scripting
girishpanchal30 Feb 27, 2026
09c83bc
fix: improve data sanitization
girishpanchal30 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions classes/Visualizer/Gutenberg/Block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,12 +596,15 @@ public function update_chart_data( $data ) {
}
$chart_type = sanitize_text_field( $data['visualizer-chart-type'] );
$source_type = sanitize_text_field( $data['visualizer-source'] );
$default_data = (int) $data['visualizer-default-data'];
$series_data = map_deep( $data['visualizer-series'], array( $this, 'sanitize_value' ) );
$settings_data = map_deep( $data['visualizer-settings'], array( $this, 'sanitize_value' ) );

update_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_TYPE, $chart_type );
update_post_meta( $data['id'], Visualizer_Plugin::CF_SOURCE, $source_type );
update_post_meta( $data['id'], Visualizer_Plugin::CF_DEFAULT_DATA, $data['visualizer-default-data'] );
update_post_meta( $data['id'], Visualizer_Plugin::CF_SERIES, $data['visualizer-series'] );
update_post_meta( $data['id'], Visualizer_Plugin::CF_SETTINGS, $data['visualizer-settings'] );
update_post_meta( $data['id'], Visualizer_Plugin::CF_DEFAULT_DATA, $default_data );
update_post_meta( $data['id'], Visualizer_Plugin::CF_SERIES, $series_data );
update_post_meta( $data['id'], Visualizer_Plugin::CF_SETTINGS, $settings_data );

if ( $data['visualizer-chart-url'] && $data['visualizer-chart-schedule'] >= 0 ) {
$chart_url = esc_url_raw( $data['visualizer-chart-url'] );
Expand All @@ -628,8 +631,8 @@ public function update_chart_data( $data ) {
}

if ( 'Visualizer_Source_Csv_Remote' === $source_type ) {
$schedule_url = $data['visualizer-chart-url'];
$schedule_id = $data['visualizer-chart-schedule'];
$schedule_url = esc_url_raw( $data['visualizer-chart-url'] );
$schedule_id = intval( $data['visualizer-chart-schedule'] );
update_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_URL, $schedule_url );
update_post_meta( $data['id'], Visualizer_Plugin::CF_CHART_SCHEDULE, $schedule_id );
} else {
Expand All @@ -642,8 +645,8 @@ public function update_chart_data( $data ) {
$json_schedule = intval( $data['visualizer-json-schedule'] );
$json_url = esc_url_raw( $data['visualizer-json-url'] );
$json_headers = esc_url_raw( $data['visualizer-json-headers'] );
$json_root = $data['visualizer-json-root'];
$json_paging = $data['visualizer-json-paging'];
$json_root = sanitize_text_field( $data['visualizer-json-root'] );
$json_paging = sanitize_text_field( $data['visualizer-json-paging'] );

update_post_meta( $data['id'], Visualizer_Plugin::CF_JSON_SCHEDULE, $json_schedule );
update_post_meta( $data['id'], Visualizer_Plugin::CF_JSON_URL, $json_url );
Expand All @@ -664,7 +667,8 @@ public function update_chart_data( $data ) {
}

if ( Visualizer_Module::is_pro() ) {
update_post_meta( $data['id'], Visualizer_PRO::CF_PERMISSIONS, $data['visualizer-permissions'] );
$permissions_data = map_deep( $data['visualizer-permissions'], array( $this, 'sanitize_value' ) );
update_post_meta( $data['id'], Visualizer_PRO::CF_PERMISSIONS, $permissions_data );
}

if ( $data['visualizer-chart-url'] ) {
Expand Down Expand Up @@ -863,4 +867,18 @@ public function add_rest_query_vars( $args, \WP_REST_Request $request ) {
}
return $args;
}

/**
* Sanitize value.
*
* @param mixed $value The value to sanitize.
* @return mixed Sanitized value.
*/
private function sanitize_value( $value ) {
if ( is_string( $value ) ) {
return sanitize_text_field( $value );
}

return $value;
}
}
2 changes: 1 addition & 1 deletion classes/Visualizer/Module/Chart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ public function getCharts() {
*
* @return array The array of chart data.
*/
private function _getChartArray( ?WP_Post $chart = null ) {
private function _getChartArray( $chart = null ) {
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the ?WP_Post type from _getChartArray reduces type-safety without changing the actual requirements (the method still assumes an object with ->ID). If this wasn’t strictly required for compatibility, consider restoring the nullable WP_Post type (or adding an explicit runtime validation + updating the docblock) so invalid callers fail fast with a clear error.

Suggested change
private function _getChartArray( $chart = null ) {
private function _getChartArray( ?WP_Post $chart = null ) {

Copilot uses AI. Check for mistakes.
if ( is_null( $chart ) ) {
$chart = $this->_chart;
}
Expand Down
Loading