Fix undefined array key warning in Live Search when no category is selected#2871
Open
SAY-5 wants to merge 1 commit into
Open
Fix undefined array key warning in Live Search when no category is selected#2871SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…lected Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2849.
Summary
When a Live Search block restricts results to
postbut no category is selected,otterSearchQuery['cat']is never written to the block attributes, sorender_blocks()accesses a missing key and PHP 8 emitsUndefined array key "cat". Guarded the read inclass-live-search.phpwith?? ''so the absent key falls back to an emptydata-catattribute, matching how the surroundingpost_typeaccess is already protected.Screenshots
Test instructions
Added
tests/test-live-search-render.php, which activates a license, renders a post-only Live Search block without acatkey, and asserts the output containsdata-cat="". It fails on the warning before the fix and passes after.Checklist before the final review