Feat: design library rework#2868
Open
abaicus wants to merge 8 commits into
Open
Conversation
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 6af0487 is ready 🛎️!
|
Add jest unit tests for the smart.js filtering engine (facet derivation, query parsing, fuzzy search incl. the indexed description, suggestTags, similar) and PHP tests for the upsell manifest logic. Also fix get_upsell_patterns() to filter out slugless entries that previously leaked into the proPatterns array as nulls. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":394.4,"q50":427.25,"q75":433.7,"cnt":10}, firstPaint: {"q25":556.6,"q50":605.15,"q75":800.4,"cnt":10}, domContentLoaded: {"q25":3432,"q50":3475.6,"q75":3490.8,"cnt":10}, loaded: {"q25":3434.1,"q50":3477.65,"q75":3492.9,"cnt":10}, firstContentfulPaint: {"q25":3932.6,"q50":3972.05,"q75":4016.4,"cnt":10}, firstBlock: {"q25":13450.4,"q50":13525.35,"q75":13603.8,"cnt":10}, type: {"q25":21.57,"q50":22.95,"q75":25,"cnt":10}, typeWithoutInspector: {"q25":19.2,"q50":20.45,"q75":21.57,"cnt":10}, typeWithTopToolbar: {"q25":28.28,"q50":29.49,"q75":33.74,"cnt":10}, typeContainer: {"q25":13.96,"q50":14.26,"q75":14.69,"cnt":10}, focus: {"q25":116.09,"q50":117.16,"q75":121.29,"cnt":10}, inserterOpen: {"q25":39.51,"q50":40.32,"q75":42.25,"cnt":10}, inserterSearch: {"q25":13.18,"q50":13.21,"q75":13.88,"cnt":10}, inserterHover: {"q25":5.16,"q50":5.54,"q75":6.09,"cnt":20}, loadPatterns: {"q25":1576.84,"q50":1615.92,"q75":1631.43,"cnt":10}, listViewOpen: {"q25":205.23,"q50":215.22,"q75":231.03,"cnt":10} |
Soare-Robert-Daniel
approved these changes
Jun 18, 2026
…into feat/design-library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/273
Closes https://github.com/Codeinwp/otter-internals/issues/274
Closes https://github.com/Codeinwp/otter-internals/issues/283
Closes https://github.com/Codeinwp/otter-internals/issues/284
Summary
Screenshots
Test instructions
Important
Pro patterns will only work once the Store PR is merged into development, provided you add these lines as a
mu-pluginor define the constants somewhere on your website.check "similar"/suggested-tags behavior.
and on the front end.
Checklist before the final review
Important
Reviewer-only:
@Soare-Robert-Daniel Same as the store PR, it would help if you can look into the non-pattern files of this PR. Thanks! 🚀
Later Edit: according to the comment below, I think we can safely move the Design Library to its own script and load it conditionally when working towards https://github.com/Codeinwp/otter-internals/issues/250.