Handled non-array option values - #1103
Open
girishpanchal30 wants to merge 1 commit into
Open
Conversation
Collaborator
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents logger cron failures when Optimole settings are absent or malformed.
Changes:
- Guarantees raw settings are returned as an array.
- Normalizes logger input before merging.
- Adds regression tests for missing, malformed, and sensitive settings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
inc/settings.php |
Normalizes raw option values to arrays. |
inc/main.php |
Safely normalizes logger data. |
tests/test-logger-data.php |
Adds logger settings regression coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
Aug 4, 2026
selul
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Return the Optimole settings as an array instead of false when the settings are not set. This is to avoid errors when merging the settings with other arrays.
Closes #1099
Other information: