Skip to content

Conversation

@abaicus
Copy link
Contributor

@abaicus abaicus commented Jan 9, 2026

All Submissions:

Changes proposed in this Pull Request:

  • Regex was not properly testing URLs to make sure that we're embedding a video.
  • Adds check to ensure we also test for video formats.

How to test the changes in this Pull Request:

  1. Use an INVALID Optimole URL from the account with which the webiste is currently connected;
  2. Add an image block and paste it as the URL for that respective image;
  3. The block should not be automatically transformed to an embed at this point, or after refreshing the page;

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@abaicus abaicus requested a review from selul January 9, 2026 10:16
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 9, 2026

Plugin build for 0df4337 is ready 🛎️!

@abaicus abaicus merged commit cac9570 into development Jan 9, 2026
11 checks passed
@abaicus abaicus deleted the fix/embed-urls branch January 9, 2026 15:27
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants