Handled missing Tagify method - #1306
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for 3863b7f is ready 🛎️!
Note You can preview the changes in the Playground |
There was a problem hiding this comment.
Pull request overview
Adds compatibility handling for Tagify instances lacking clearPersistedData.
Changes:
- Adds a persistence-clearing fallback using
setPersistedData. - Adds an E2E regression test for featured-image action saving.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
js/ActionPopup/index.js |
Adds and uses the Tagify compatibility helper. |
tests/e2e/specs/import.spec.js |
Tests saving when persistence methods are unavailable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handled the missing
clearPersistedDatamethod in theActionPopupcomponent. The code now checks whether the method exists before calling it; if it doesn't, it calls the fallback methodsetPersistedDatawith an empty array to clear the persisted data.Check before Pull Request is ready:
Closes #1305