fix: update temporary z-index for Popover, Flyout, and Toast - #3403
Conversation
|
View your CI Pipeline Execution ↗ for commit 7dc0b9f ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
==========================================
- Coverage 90.86% 90.44% -0.43%
==========================================
Files 403 275 -128
Lines 6681 5765 -916
Branches 2169 1915 -254
==========================================
- Hits 6071 5214 -857
+ Misses 601 542 -59
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b91ecdf to
368a85b
Compare
1511526 to
2b3d185
Compare
Cherry-picked content from 11d9427 on kl-gmt-1676-gamut-skills, which had the same edit committed to the wrong branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a75fcedaf1df66bdd626582--gamut-preview.netlify.app |
There was a problem hiding this comment.
Pull request overview
This PR raises temporary BodyPortal z-index values so Popover-based surfaces (including Flyout tooltip paths) and Toaster reliably render above Overlay (default zIndex={3}) until GM-624 introduces a shared z-index scale.
Changes:
- Set
BodyPortal zIndex={5}for portalledPopoverand portalledPopoverContainer. - Set
BodyPortal zIndex={4}forToasterso toasts render aboveOverlay. - Document the temporary Tier-2 ordering in the
gamut-z-indexagent skill and add an Nx release version plan entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/gamut/src/Toaster/index.tsx | Raises the Toaster portal z-index to 4 to clear Overlay portals. |
| packages/gamut/src/PopoverContainer/PopoverContainer.tsx | Raises the portalled PopoverContainer portal z-index to 5. |
| packages/gamut/src/Popover/elements.tsx | Raises Popover’s portal z-index to 5 in both animated and non-animated portal paths. |
| packages/gamut/agent-tools/skills/gamut-z-index/SKILL.md | Updates internal documentation to include the new temporary Tier-2 ordering and references. |
| .nx/version-plans/version-plan-1785874968484.md | Adds a patch version plan for the temporary z-index changes. |
| gamut: patch | ||
| --- | ||
|
|
||
| Set temporary zindex values for Popover related components |
| // TEMPORARY: zIndex override to stay above Overlay's default of 3 until GM-624 lands a shared z-index scale | ||
| <BodyPortal zIndex={5} {...rest} /> |
| // TEMPORARY: zIndex override to stay above Overlay's default of 3 until GM-624 lands a shared z-index scale | ||
| <BodyPortal zIndex={4}> |
| // TEMPORARY: zIndex override to stay above Overlay's default of 3 until GM-624 lands a shared z-index scale | ||
| return <BodyPortal zIndex={5}>{content}</BodyPortal>; |
Overview
Raises temporary z-index values so Popover-related surfaces and toasts sit above Overlay (default z-index 3) until a shared scale lands in GM-624.
BodyPortalzIndex={5}on Popover portal paths inPopover/elements.tsx(animated and non-animated)BodyPortalzIndex={5}onPopoverContainerwhen content is portaledBodyPortalzIndex={4}onToasterPR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs