Skip to content

fix(percipioTheme): update border-secondary to navy-600#3374

Merged
LinKCoding merged 2 commits into
mainfrom
kl-percipio-theme-borderv3
Jun 16, 2026
Merged

fix(percipioTheme): update border-secondary to navy-600#3374
LinKCoding merged 2 commits into
mainfrom
kl-percipio-theme-borderv3

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Overview

Updates percipioTheme's border-secondary to navy-600 for better contrast

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Set the theme to be percioTheme
  2. Go to the Tag story
  3. Check that the tertiary badge has a border of navy-600
  4. Check that the navigation tag badge has a border of navy-600
  5. Optionally, check against current prod
  6. ....
  7. Finish and do a celebratory dance

PR Links and Envs

N/A

@nx-cloud

nx-cloud Bot commented Jun 15, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 73916eb


☁️ Nx Cloud last updated this comment at 2026-06-16 15:15:50 UTC

@LinKCoding LinKCoding changed the title update border-secondary fix(percipioTheme): update border-secondary to navy-600 Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (5b85bd7) to head (73916eb).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
- Coverage   90.38%   90.26%   -0.13%     
==========================================
  Files         398      377      -21     
  Lines        6576     6186     -390     
  Branches     2132     2023     -109     
==========================================
- Hits         5944     5584     -360     
+ Misses        624      594      -30     
  Partials        8        8              
Flag Coverage Δ
main ?
pull-request 90.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LinKCoding LinKCoding marked this pull request as ready for review June 15, 2026 15:18
@LinKCoding LinKCoding requested a review from a team as a code owner June 15, 2026 15:18
@LinKCoding LinKCoding force-pushed the kl-percipio-theme-borderv3 branch from 4a3ca1b to 73916eb Compare June 16, 2026 15:13
@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 72.0.1-alpha.18240e.0 npm diff
@codecademy/gamut-icons 9.57.9-alpha.18240e.0 npm diff
@codecademy/gamut-illustrations 0.58.15-alpha.18240e.0 npm diff
@codecademy/gamut-kit 3.0.1-alpha.18240e.0 npm diff
@codecademy/gamut-patterns 0.10.34-alpha.18240e.0 npm diff
@codecademy/gamut-styles 20.0.2-alpha.18240e.0 npm diff
@codecademy/gamut-tests 6.0.5-alpha.18240e.0 npm diff
@codecademy/variance 0.26.2-alpha.18240e.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.18240e.0 npm diff

@github-actions

Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding merged commit 36a157d into main Jun 16, 2026
18 checks passed
@LinKCoding LinKCoding deleted the kl-percipio-theme-borderv3 branch June 16, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants