feat(cli): add Windows toast notification for task completion - #1118
feat(cli): add Windows toast notification for task completion#1118rekty wants to merge 2 commits into
Conversation
Closes CodebuffAI#1089 FriendliAI serves several models already in the catalog under other providers (GLM-5.2, MiniMax-M2.5). Register their HuggingFace-cased IDs under the friendli/ prefix so a private-backend routing layer can pick them up without any public code changes beyond this catalog entry. Changes: - Add 'friendli' to ALLOWED_MODEL_PREFIXES - Add friendliModels map with two serverless models - Spread friendliModels into the canonical models set - Add friendli.ai to providerDomains and getLogoForModel
Closes CodebuffAI#1111 When speakers are muted or the user steps away, the terminal bell (BEL character in the OSC title sequence) is easy to miss. Add a native Windows toast notification that fires when a run completes so users always get a visual cue. - cli/src/utils/notification.ts: new utility using .NET ToastNotificationManager via PowerShell — works on every Windows 10+ machine without extra dependencies - cli/src/hooks/helpers/send-message.ts: call notifyTaskComplete() after finalizeQueueState on successful completion The Desktop (Electron) app can also import notifyTaskComplete directly for its own completion events.
|
The core idea — a Windows toast notification as a fallback when the terminal bell is missed — is reasonable and But this PR bundles in an entirely unrelated change to Separately, the Please split this into a single-purpose PR for the Windows toast feature, drop the model-config changes entirely (or file them separately with real, verifiable model IDs and provider justification), and reconcile the doc comment with the actual wiring before resubmitting. |
{
"title": "feat(cli): add Windows toast notification for task completion",
"head": "rekty:feat/desktop-notification",
"base": "main",
"body": "Closes #1111\n\nWhen speakers are muted or the user steps away, the terminal bell (BEL character in the OSC title sequence) is easy to miss. This adds a native Windows toast notification that fires when a run completes so users always get a visual cue.\n\n### Changes\n\n-
cli/src/utils/notification.ts(new) —notifyDesktop(title, body)uses .NETToastNotificationManagervia PowerShell. Works on every Windows 10+ machine without extra dependencies. Falls back gracefully on any error.notifyTaskComplete(agentName?)is the convenience wrapper.\n-cli/src/hooks/helpers/send-message.ts— callsnotifyTaskComplete()afterfinalizeQueueStateon successful completion.\n\n### Platform behavior\n\n| Platform | Notification |\n|---|---|\n| Windows | Native toast (via PowerShell .NET interop) |\n| macOS / Linux | No-op (terminal bell already provides the cue) |\n\nThe Desktop (Electron) app can also importnotifyTaskCompletedirectly for its own completion events.\n\n### Verification\n\n-bun test cli/src/hooks/helpers/__tests__/send-message.test.ts— pre-existing failure (missingweb-tree-sitterdep), unrelated to this change\n-notification.tsis self-contained with no external dependencies"}