Skip to content

Fix Freebuff CLI auth code handling#604

Merged
jahooma merged 1 commit intomainfrom
jahooma/fix-freebuff-auth-code
May 6, 2026
Merged

Fix Freebuff CLI auth code handling#604
jahooma merged 1 commit intomainfrom
jahooma/fix-freebuff-auth-code

Conversation

@jahooma
Copy link
Copy Markdown
Contributor

@jahooma jahooma commented May 6, 2026

Summary

  • Generate CLI login URLs from the request origin to avoid apex/www host drift during OAuth.
  • Parse CLI auth codes from the right and trim copied values so validation handles malformed copies and dotted fingerprint IDs.
  • Add diagnostic Freebuff logging for invalid auth-code validation without logging full codes or hashes.

Tests

  • bun test web/src/app/onboard/tests/helpers.test.ts
  • bun run --cwd web test -- --runTestsByPath src/app/onboard/tests/helpers.test.ts --runInBand
  • bun run --cwd freebuff/web typecheck
  • bun run --cwd web typecheck

@jahooma jahooma merged commit ab65f2e into main May 6, 2026
35 checks passed
@jahooma jahooma deleted the jahooma/fix-freebuff-auth-code branch May 6, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant