London | 26-ITP-May | Dipa Sarker | Sprint 3 | Practice TDD

[Dipa-Sarker]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

1. Wrote Jest tests for the required functions before implementing the code (Test-Driven Development).
2. Implemented the count function to satisfy all test cases.
3. Implemented the repeatStr function to satisfy all test cases.
4. Implemented the getOrdinalNumber function to satisfy all test cases.
5. Verified that all tests pass successfully using the VS Code test runner.

[tiakavousi]

Great suite of test cases, can we think of some more edge cases to test, making sure the function can handle tricky arguments?

[Dipa-Sarker]

Thank you for your review. I have added several edge cases to the tests. Please let me know if I've understood your question correctly.

[tiakavousi]

Readability and naming are spot on!

I'm curious about the control flow choices here. Could you share why you opted for the else if chain and wrapped the final return in an else block?

[Dipa-Sarker]

There are multiple conditions to check that's why I used else if inside if...else statement. I wrapped the final return in else cause none of the above conditions are true for "th", so for "th" else block will execute. That's my thought actually.