London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Coursework/sprint 2#1458
Open
russom-g wants to merge 19 commits into
Open
London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Coursework/sprint 2#1458russom-g wants to merge 19 commits into
russom-g wants to merge 19 commits into
Conversation
added 12 commits
June 24, 2026 22:15
…t different stages.
…function needs fixing.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
added
the
Needs Review
Liam310
added
Review in progress
Liam310
reviewed
Jul 6, 2026
Comment on lines
+38
to
+39
| // The return value of pad when it is called for the first time is 00. this is because the value of num is 0 and the pad function adds a 0 to the front of the string until the num characters has at least 2 characters. | ||
|
|
There was a problem hiding this comment.
To be precise, what exactly is the return value of pad? I think you know what it is, but 00 doesn't quite exactly describe it
Author
There was a problem hiding this comment.
Hi Liam. Thanks for reviewing my code.
The exact return value is 0 . It ads a single 0 instead of two 0s.
There was a problem hiding this comment.
Not quite - what data type is the return value of pad?
Liam310
reviewed
Jul 6, 2026
Comment on lines
+47
to
+48
|
|
||
| // The return value of pad when it is called for the last time is 01. This is because the pad function adds a 0 to the front of the string if the characters of the string are less than 2. No newline at end of file |
Liam310
reviewed
Jul 6, 2026
Liam310
reviewed
Jul 6, 2026
Liam310
reviewed
Jul 6, 2026
Liam310
reviewed
Jul 6, 2026
Liam310
reviewed
Jul 6, 2026
Liam310
reviewed
Jul 6, 2026
Liam310
removed
the
Review in progress
Liam310
added
the
Reviewed
added 4 commits
July 7, 2026 22:31
…d added in order to test case for 1:00am to work
…declaring a parameter updated.
Liam310
reviewed
Jul 13, 2026
Comment on lines
+25
to
+26
| let card = " "; | ||
| if (card.includes ) |
There was a problem hiding this comment.
These changes are in the Sprint-3 folder and so should not be part of this PR. Please undo these changes on this branch 🙂
|
Hey @russom-g! Just highlighting that you do still have some outstanding comments left on here. There's not a lot of work to do and I'd be happy to mark as complete once they are sorted! |
…lue.js File removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I manage to predict, find, interpret and fix the errors in programs. I debugged each files and corrected the programs. I implemented functions based on requirements. I interpreted programs using documentations.