London | ITP-JAN-2026 | Said Fayaz Sadat | Sprint 3 | coursework/sprint-3/implement-and-rewrite-tests by fayaz551 · Pull Request #1221 · CodeYourFuture/Module-Structuring-and-Testing-Data

fayaz551 · 2026-03-07T22:41:26Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR addresses the Implement and Rewrite Tests backlog for Sprint 3. I have separated this from the main coursework branch to ensure correct validation by the GitHub bot.
Implemented functions in the implement folder to pass existing criteria.
Refactored and rewrote test suites in the rewrite-tests-with-jest folder to improve and follow Jest best practices.
Ensured all tests pass locally before submission.

Questions

n/a

…rewrite tests

fayaz551 · 2026-03-07T22:42:59Z

@cjyuan created new branch from main and transferred my work from old branch to new branch.

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

cjyuan · 2026-03-08T06:30:37Z

This description in the Changelist section does not quite explain what you have changed in this PR.

fixed the branches and PR to match the acceptance criteria of Sprint-3.

…e fractions

…get-value-card to test file

…id angle check in the beginning

fayaz551 · 2026-03-08T16:55:52Z

This description in the Changelist section does not quite explain what you have changed in this PR.

fixed the branches and PR to match the acceptance criteria of Sprint-3.

updated the description to explain what have I done in this PR.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

cjyuan · 2026-03-09T04:40:52Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+test(`should return "Invalid angle" when angle < 1 `, () => {
+  expect(getAngleType(-1)).toEqual("Invalid angle");
+});
+
+test(`should return "Invalid angle" when angle > 360 `, () => {
+  expect(getAngleType(361)).toEqual("Invalid angle");
+});
+
+// Largest valid angle(boundary case)
+test(`should return "Straight angle" when angle is the maximum valid value (360)`, () => {
+  expect(getAngleType(360)).toEqual("Straight angle");
+});
+ // Smallest valid angle(boundary case)
+test(`should return "Acute angle" when angle is the minimum valid value (1)`, () => {
+  expect(getAngleType(1)).toEqual("Acute angle");
+});


The "definition of angles" in these tests do not quite match the specification defined in
Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js.
Please check the specification and update these tests and the function accordingly.

updated the description and specification of test and function.

cjyuan · 2026-03-10T00:30:57Z

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

+    return "Straight angle"; 
+  }
+
+  return "Invalid angle";


Please check carefully the specification on lines 4-9.

cjyuan · 2026-03-10T00:32:07Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+ // Smallest valid angle(boundary case)
+test(`should return "Acute angle" when angle is the minimum valid value (1)`, () => {
+  expect(getAngleType(1)).toEqual("Acute angle");
+});


You already have a test like this on line 11.

cjyuan · 2026-03-10T00:37:18Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+test(`should return "Invalid angle" for angles less than 1°`, () => {
+  expect(getAngleType(-1)).toEqual("Invalid angle");
+});
+
+test(`should return "Invalid angle" for angles greater than 360°`, () => {
+  expect(getAngleType(361)).toEqual("Invalid angle");
+});
+
+// Largest valid angle(boundary case)
+test(`should return "Straight angle" when angle is the maximum valid value (360)`, () => {
+  expect(getAngleType(360)).toEqual("Straight angle");
+});


You could consider grouping all invalid cases into a category:

should return "Invalid angle" when angle <= _________ or angle >= _________.

and then test few invalid values, including both boundary cases.

Note: We can use symbols and notation if they help make the description more concise.

cjyuan · 2026-03-10T00:44:06Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test("should return false when denominator is zero", () => {
+  expect(isProperFraction(1, 0)).toBe(false);
+});


This is a good category.

0/0 could be a good value to test.

cjyuan · 2026-03-10T00:46:43Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

 });
+
+// Category 3: Improper fractions (numerator >= denominator)
+test("should return false when numerator is greater than or equal to denominator", () => {


Could consider making the description more precise as:

should return false when |numerator| > |denominator|

or

should return false when abs(numerator) > abs(denominator)

corrected the branch to individual folders of sprint-3 implement and …

62f2bc9

…rewrite tests

fayaz551 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 7, 2026

cjyuan reviewed Mar 8, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 8, 2026

fayaz551 added 4 commits March 8, 2026 15:17

Updated isProperFraction implementation and correct tests for negativ…

5218dc7

…e fractions

added implementation for invalid cards and removed direct calls from …

4541230

…get-value-card to test file

ensure only valid cards return numbers

60dd1f1

return "Invalid angle" for angles <0 or >360 and added explicit inval…

d0b2a26

…id angle check in the beginning

fayaz551 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 8, 2026

cjyuan reviewed Mar 8, 2026

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated Show resolved Hide resolved

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated Show resolved Hide resolved

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 8, 2026

fayaz551 added 2 commits March 8, 2026 20:07

clarify invalid angle tests using valid range 0–360

22cbee3

fixed the indentation in the function

9ab2716

fayaz551 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 8, 2026

fayaz551 mentioned this pull request Mar 8, 2026

ITP-JAN-2026 | Structuring and testing data | Said Fayaz Sadat fayaz551/My-Coursework-Planner#20

Open

cjyuan reviewed Mar 8, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 8, 2026

fayaz551 added 5 commits March 8, 2026 23:51

fixed the indentation issue

a517fe7

categorize cases with descriptive messages

40bd7ce

used shorter descriptive text for test

8c587a2

implementation to handle boundary angles correctly with test case

560d5c6

implementation for small valid angle and test case for it

401d8cb

smallest valid angle

48cfeba

fayaz551 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 9, 2026

cjyuan reviewed Mar 9, 2026

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js Show resolved Hide resolved

cjyuan reviewed Mar 9, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 9, 2026

fayaz551 added 2 commits March 9, 2026 23:18

updated the test description and function to match task specification

595de00

tests to include negative numerator and denominator cases

e21d0fd

fayaz551 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 9, 2026

cjyuan reviewed Mar 10, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 10, 2026

Uh oh!

Conversation

fayaz551 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

fayaz551 commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan commented Mar 8, 2026

Uh oh!

fayaz551 commented Mar 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

fayaz551 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fayaz551 commented Mar 7, 2026 •

edited

Loading