Sheffield | 26-ITP-Jan | Mahammad Osman| Sprint 2 | Coursework#1206
Open
Darkidd77 wants to merge 11 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahammad Osman| Sprint 2 | Coursework#1206Darkidd77 wants to merge 11 commits intoCodeYourFuture:mainfrom
Darkidd77 wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
…m, and getLastDigit functions
…me to 12-hour format with proper padding and period indication
Darkidd77
added
the
Needs Review
cjyuan
reviewed
Mar 7, 2026
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| let hours = Number(time.slice(0, 2)); // if its const it will throe an TypeError you cant assign a const variable later on | ||
| const minutes = time.slice(3, 5); |
Contributor
There was a problem hiding this comment.
We could also extract the last two characters as time.slice(-2).
Author
There was a problem hiding this comment.
I see, yes it's a better way. Thank you
cjyuan
added
Reviewed
Darkidd77
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
completes the Week 2 coursework, focusing on identifying, predicting, and resolving syntax and logic bugs across the provided error and debug exercises.