Skip to content

Birmingham | 26-ITP-JAN | Merve Reis | Sprint 3 | Implement and Rewrite Test#1122

Open
mervereis wants to merge 5 commits intoCodeYourFuture:mainfrom
mervereis:coursework/sprint-3
Open

Birmingham | 26-ITP-JAN | Merve Reis | Sprint 3 | Implement and Rewrite Test#1122
mervereis wants to merge 5 commits intoCodeYourFuture:mainfrom
mervereis:coursework/sprint-3

Conversation

@mervereis
Copy link

@mervereis mervereis commented Mar 1, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I added/updated functions and added/updated test cases for coverage.

@mervereis mervereis added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 1, 2026
@mervereis mervereis closed this Mar 1, 2026
@mervereis mervereis reopened this Mar 1, 2026
@mervereis mervereis changed the title Birmingham | 26-ITP-JAN | Merve Reis | Sprint 3 | Module Structuring and Testing Data Birmingham | 26-ITP-JAN | Merve Reis | Sprint 3 | Implement and Rewrite Test Mar 1, 2026
@mervereis mervereis mentioned this pull request Mar 7, 2026
Open
cjyuan
cjyuan reviewed Mar 9, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 9, 2026
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 9, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 10, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mervereis @cjyuan