London | 26-ITP-Jan | Ebrahim Moqbel | Sprint 2 | coursework/sprint-2

[Ebrahim-Moqbel]

Learners, PR Template

Self checklist

• [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• [ x] My changes meet the requirements of the task
• [ x] I have tested my changes
• [ x] My changes follow the style guide

Changelist

I completed the following filles :

• key errors
• mandatory debug
• mandatory implement
• mandatory interpret

[cjyuan]

Code is not consistently formatted.

Consider install prettier VSCode extension and enable formatting on save/paste on VSCode
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md

Then, resave all your files (in Sprint 2) to ensure all code is consistently formatted.

[Ebrahim-Moqbel]

I have installed prettier to VS code and selected the copy-paste save format. I have been reading about reverting and reseting commits in git. I know how to. revert a specific commit but I still need to know how can I select all the commits.

I was wondering if you need me revert all of them and commit them again. Also After installing prettier I still find the format the same and I think it's consistent.

[cjyuan]

If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.

If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:
(1) Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
(2) Edit settings.json and set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

---

Can you also address all the follow-up questions in the inline comments.

[Ebrahim-Moqbel]

I have addressed the questions above and regarding prettier I have installed it and selected the the format to be on paste as well but I may still need to Edit settings.json but I am still not sure how to access to this settings whether they are in an external file or in built settings in VS code.

In the bellow video prettier asked for configuration and I am hoping you could advise me what I expected to do at this stage. Thanks xx

[cjyuan]

I don't see any video. I only see an image.

Prettier won't format the code if there is a syntax error in the code.

The file settings.json is located at
$HOME/Library/Application\ Support/Code/User/settings.json.

If you still have problem setting Prettier as your default formatter, try to seek for assistance on Saturday in the workshop?

---

Thanks for the responses to each comment. All good now.