London | JAN-2026 ITP | Ebrahim Moqbel | Sprint 1 | Coursework#1074
Open
Ebrahim-Moqbel wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
London | JAN-2026 ITP | Ebrahim Moqbel | Sprint 1 | Coursework#1074Ebrahim-Moqbel wants to merge 13 commits intoCodeYourFuture:mainfrom
Ebrahim-Moqbel wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Ebrahim-Moqbel
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Ebrahim-Moqbel
changed the title
Ebrahim-Moqbel
added
Needs Review
cjyuan
reviewed
Mar 5, 2026
cjyuan
added
Reviewed
Ebrahim-Moqbel
added
the
Needs Review
cjyuan
reviewed
Mar 5, 2026
| // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
|
||
| let initials = ``; | ||
| let initials = `the initials is ${firstName.charAt(0)}, ${middleName.charAt(0), lastName.charAt(0)}`; |
Contributor
There was a problem hiding this comment.
What the description on lines 5-6 mean is:
If we output the value of
initialsafter line 8, we should seeCJKin the output.
Currently, we would see the initials is .... instead of CJK.
Author
There was a problem hiding this comment.
I have made a new commit with the changes.
Sprint-1/1-key-exercises/4-random.js
Outdated
Comment on lines
+12
to
+14
| // math.random will generate a random number between (0,1) inclusivly | ||
| // (maximum - minimum + 1) provide a range of generated random number | ||
| // num is a random whole number (1,100) inclusivly |
Contributor
There was a problem hiding this comment.
Using the interval notation, we could express
math.random will generate a random number between (0,1) inclusivly
as
Math.random() returns a random number in [0, 1).
[0, 1)means, include 0, exclude 1.- No need to further specify inclusively or exclusively.
- Less wordy, more precise.
We could do the same to
num is a random whole number (1,100) inclusivly
cjyuan
removed
the
Needs Review
Ebrahim-Moqbel
added
the
Needs Review
cjyuan
reviewed
Mar 6, 2026
Sprint-1/1-key-exercises/4-random.js
Outdated
| // math.floor will make the number as a whole and remove any decimals or more likely to round the the nearest whole number | ||
| // math.random returns a random number in [0,1) | ||
| // (maximum - minimum + 1) provide a range of generated random number | ||
| // num is a random whole number [1,100) |
Contributor
There was a problem hiding this comment.
Can the value of num be 100? That is, canthe generated random number include 100?
Author
There was a problem hiding this comment.
No the notation ( , ) would exclude the number therefore 100 wouldn't be generated.
Contributor
There was a problem hiding this comment.
You figured out Math.random returns a random number in [0, 1).
Can you use the interval notation to describe what each of these expressions does, and the range of the numbers it may produce?
Math.random() * (maximum - minimum + 1)Math.floor(Math.random() * (maximum - minimum + 1))Math.floor(Math.random() * (maximum - minimum + 1)) + minimum
cjyuan
removed
the
Needs Review
Ebrahim-Moqbel
added
the
Needs Review
Contributor
|
What about this comment: #1074 (comment) Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
|
cjyuan
removed
the
Needs Review
Ebrahim-Moqbel
added
the
Needs Review
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
completed all of the bellow filles :
Key exercises
Mandatory errors
Mandatory interpret
Stretch exploration
Questions
N/A