Manchester | ITP-May-26 | Joanne O'Malley | Sprint 2 | Wireframe#929
Manchester | ITP-May-26 | Joanne O'Malley | Sprint 2 | Wireframe#929joanne342 wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joanne342
added
🏕 Priority Mandatory
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This is looking really good! I left a couple of questions, but they're both pretty minor things to think about :)
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| grid-template-rows: auto 1fr auto; /* Add this */ |
There was a problem hiding this comment.
What does your "Add this" comment here mean?
Same below with > a { align-self?
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| <img src="https://docs.github.com/assets/cb-2058/mw-1440/images/help/branches/pr-retargeting-diagram1.webp" alt="Branch image" /> |
There was a problem hiding this comment.
Your alt text here isn't very descriptive. There isn't necessarily a great description of the visuals going on here (in which case you may want to use empty alt text to suggest to a screen reader "this image is decorative, it doesn't matter"), or you may want to try to think of a more descriptive alt text that would help someone who can't see the image.
illicitonion
added
Reviewed
joanne342
changed the title
This comment has been minimized.
This comment has been minimized.
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
|
Hello. Do I have permission to reopen it? I don't see the option anywhere. I didn't do it before because of having a full time job and 1.5-2hr commute and didn't even have time to turn my computer on during weekdays so I postponed ITP to May. Now I've figured out a shortcut to the train station (was taking the bus before) and can get home in an hour so I made the requested changes on this and changed Jan to May in the title. |
illicitonion
changed the title
joanne342
added
the
Needs Review
illicitonion
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
Edit the HTML and CSS so it looks like the wireframe image and briefly explain wireframes, branches and readmes including button links to additional info.
Questions
N/A