-
-
Notifications
You must be signed in to change notification settings - Fork 431
Sheffield | 26-ITP-January | Connor Parsons | Sprint 2 | Form-Controls #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
connorpar
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
connorpar:Form-Control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c890f57
Updated Form
connorpar 503388a
A couple Fixes
connorpar aae8f8b
added extra validation for name
connorpar d48d2f8
Removed unnecessary comments
connorpar 0d6b4cf
Fixed some errors
connorpar 3667dc5
added minlength attribute for name field
connorpar de94f56
added required field for radio buttons
connorpar ad57458
added "name" attributes so that the inputs from the form are sent.
connorpar 162702d
added the required attribute for the name field
connorpar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,74 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="description" content=""> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| <h2>T-Shirt Order</h2> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" minlength="2" pattern=".*\S.*" title="Name must have at least 2 characters" placeholder="Enter Name"> | ||
| <br><br> | ||
| </div> | ||
| <div> | ||
| <label for="email">Email Address:</label> | ||
| <input id="email" type="email" required placeholder="@.com"> | ||
| <br><br> | ||
| </div> | ||
| <div> | ||
| <br><br> | ||
| <fieldset> | ||
| <legend> | ||
| <h3>Choose T-Shirt Colour</h3> | ||
| </legend> | ||
| <br><br> | ||
| <div> | ||
| <input type="radio" name="Shirt_Colour" id="White" Value="White"> | ||
| <label for="White">White</label> | ||
| <br><br><br> | ||
| </div> | ||
| <div> | ||
| <input type="radio" name="Shirt_Colour" id="Black" Value="Black"> | ||
| <label for="Black">Black</label> | ||
| <br><br><br> | ||
| </div> | ||
| <div> | ||
| <input type="radio" name="Shirt_Colour" id="Grey" Value="Grey"> | ||
| <label for="Grey">Grey</label> | ||
| <br><br><br> | ||
| </div> | ||
| </fieldset> | ||
| <br> | ||
| <div> | ||
| <br> | ||
| <h3>Choose your size:</h3> | ||
| <label for="size">Size:</label> | ||
| <select id="size" required> | ||
| <option value="">Select Size</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| </div> | ||
| <br><br><br> | ||
| <button type="submit">Submit</button> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <br><br> | ||
| <h2>By Connor Parsons</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.