Manchester | 26-ITP-Jan | Liban Jama | Sprint 2 | Form-Controls #1082
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,66 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <title>My form exercise</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
|
|
||
| <main> | ||
| <form> | ||
|
|
||
| <p> | ||
| <label for="name">Name</label> | ||
| <input type="text" id="name" name="user_name" | ||
| placeholder="John Smith" | ||
| required minlength="2" maxlength="18"> | ||
| </p> | ||
|
|
||
| <p> | ||
| <label for="email">Email</label> | ||
| <input type="email" id="email" name="user_email" | ||
| placeholder="johnsmith@hotmail.com" | ||
| required minlength="5" maxlength="32"> | ||
| </p> | ||
|
|
||
| <p>Colour</p> | ||
|
|
||
| <input type="radio" id="red" name="colour" value="red" required> | ||
| <label for="red">Red</label><br> | ||
|
|
||
| <input type="radio" id="blue" name="colour" value="blue"> | ||
| <label for="blue">Blue</label><br> | ||
|
|
||
| <input type="radio" id="green" name="colour" value="green"> | ||
| <label for="green">Green</label> | ||
|
|
||
|
There was a problem hiding this comment. well done for the good work. |
||
| <p> | ||
| <label for="size">Size</label> | ||
| <select id="size" name="size" required> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> | ||
|
There was a problem hiding this comment. There is a small error that comes up when I validate this HTML. Can you check what's showing & try and fix it? |
||
| </p> | ||
|
|
||
| <p> | ||
| <button type="submit">Submit</button> | ||
| </p> | ||
|
|
||
|
There was a problem hiding this comment. How do we submit the form? is there an element to use to submit the form ? |
||
| </form> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <h2>By LIBAN JAMA</h2> | ||
| </footer> | ||
|
|
||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want
maxlengthon name / email address? Could a name be longer than 18 characters, or an email longer than 32 characters?