Skip to content

West Midlands | ITP-May-2026 | Alina Sofragiu | Sprint 3 | Programmer Humour - #559

Open
sofragiualina wants to merge 1 commit into
CodeYourFuture:mainfrom
sofragiualina:feature/xkcd
Open

West Midlands | ITP-May-2026 | Alina Sofragiu | Sprint 3 | Programmer Humour #559
sofragiualina wants to merge 1 commit into
CodeYourFuture:mainfrom
sofragiualina:feature/xkcd

Conversation

@sofragiualina

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

done

@sofragiualina sofragiualina added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 15, 2026
@webmonch webmonch added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 21, 2026
const image = document.createElement("img");

image.src = data.img;
image.alt = data.title;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better suited field we could use for alt property from the returned json?

@webmonch

Copy link
Copy Markdown

Good job! Very clean solution and nice error handling.

@webmonch webmonch added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants