London | 26-ITP-May | Damilola Odumosu | Sprint 3 | Programmer humour - #551
Open
d-odumosu wants to merge 1 commit into
Open
London | 26-ITP-May | Damilola Odumosu | Sprint 3 | Programmer humour#551d-odumosu wants to merge 1 commit into
d-odumosu wants to merge 1 commit into
Conversation
d-odumosu
added
Needs Review
webmonch
added
Review in progress
webmonch
reviewed
Aug 21, 2026
| alt.textContent = result.alt; | ||
| console.log(result); | ||
| } catch (error) { | ||
| console.log(error.message); |
There was a problem hiding this comment.
Is there a better function to log errors?
webmonch
reviewed
Aug 21, 2026
| try { | ||
| const response = await fetch(url); | ||
| if (!response.ok) { | ||
| throw new Error(`Response status: ${response.status}`); |
webmonch
reviewed
Aug 21, 2026
| const image = document.getElementById("image"); | ||
| const alt = document.getElementById("alt"); | ||
|
|
||
| async function getImg() { |
There was a problem hiding this comment.
Do you think this function name clearly describes what it does?
Author
There was a problem hiding this comment.
maybe getImage could be better?
There was a problem hiding this comment.
I was mostly thinking here that it in addition to getting image it sets values for some text fields, but this is just a nitpick.
webmonch
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed tasks for programmer humour