Skip to content

London|25-SDC-November| Donara Blanc |Sprint 2 |Linked_list#92

Open
donarbl wants to merge 2 commits intoCodeYourFuture:mainfrom
donarbl:sprint-2-linked-list
Open

London|25-SDC-November| Donara Blanc |Sprint 2 |Linked_list#92
donarbl wants to merge 2 commits intoCodeYourFuture:mainfrom
donarbl:sprint-2-linked-list

Conversation

@donarbl
Copy link

@donarbl donarbl commented Jan 31, 2026 •
edited
Loading

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Refactored pop_tail() to call remove() instead of duplicating pointer logic

@github-actions

This comment has been minimized.

Sign in to view
@donarbl donarbl added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jan 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@donarbl donarbl changed the title London|25-SDC-November| Donara Blanc |Sprint2 |Linked_list London|25-SDC-November| Donara Blanc |Sprint 2 |Linked_list Jan 31, 2026
@donarbl donarbl added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
cjyuan
cjyuan reviewed Feb 27, 2026
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good.

We could also just call remove() in pop_tail() to remove the tail -- less code to maintain.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 27, 2026
@cjyuan
Copy link

cjyuan commented Feb 27, 2026

Can you tidy up the PR description and include a Changelist section to it?

image

@donarbl
Update linked_list.py
1638201 
Refactored the code to be concise
@donarbl
Copy link
Author

donarbl commented Feb 27, 2026

the description is tidy and changelist is added

@cjyuan
Copy link

cjyuan commented Feb 27, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Complexity The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@donarbl @cjyuan