Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Analyse and Refactor Functions#122
Open
HassanOHOsman wants to merge 19 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Analyse and Refactor Functions#122HassanOHOsman wants to merge 19 commits intoCodeYourFuture:mainfrom
HassanOHOsman wants to merge 19 commits intoCodeYourFuture:mainfrom
Conversation
… reduce complexity and save time
…he code was refactored
…ready checked while looping
…second number (difference between target and first number)
…oid scanning through each element in an array which is not efficient.
…the set. if not it gets added to the set of unique numbers
…ay since order matters. Also, once element is checked it gets added to the set to to avoid duplication as checking goes ahead
…ers found in both arrays (1&2) are stored in uniqueCommonItems
HassanOHOsman
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
In this pull request, I analysed the functions in the exercises and explained their time complexity, space complexity, and optimal time complexity using Big O notation. I then refactored the code to improve efficiency and reduce complexity, using both JavaScript and Python.