Modernize GlobalDefaultJsonSerializationoptions to .NET 10 and fix Newtonsoft global config - #2113
Closed
vladimir-pecanac-main wants to merge 1 commit into
Closed
Conversation
…wtonsoft global config - Retarget app and tests to net10.0; bump test packages - Configure Newtonsoft globally via AddControllers().AddNewtonsoftJson (Microsoft.AspNetCore.Mvc.NewtonsoftJson) instead of JsonConvert.DefaultSettings, which does not affect MVC output formatters - SaveProduct now returns Ok(product) so the response is JSON, not a hand-serialized string written as text/plain - Use SnakeCaseUpper for the minimal-API ConfigureHttpJsonOptions to show controller and minimal-API options are independent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the
json-csharp/GlobalDefaultJsonSerializationoptionssample to .NET 10 and fixes the Newtonsoft global-configuration example.net10.0; refresh test packages.AddControllers().AddNewtonsoftJson(...)(packageMicrosoft.AspNetCore.Mvc.NewtonsoftJson) rather thanJsonConvert.DefaultSettings, which only affects directJsonConvertcalls and not the MVC output formatters.SaveProductnow returnsOk(product), so the response goes through the formatter as JSON instead of a hand-serialized string that MVC writes astext/plain.ConfigureHttpJsonOptionsusesSnakeCaseUpperto make clear that controller and minimal-API JSON options are independent types.Build and tests pass on net10.0.