Encode URL components, not whole URLs, in UrlEncodingAndDecoding - #2109
Closed
vladimir-pecanac-main wants to merge 1 commit into
Closed
Encode URL components, not whole URLs, in UrlEncodingAndDecoding#2109vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
Encode URL components, not whole URLs, in UrlEncodingAndDecoding The three examples encoded the entire URL, which destroys the ://, ? and # that give a URL its structure and yields an unusable result. Encode only the query-string value and interpolate it into the URL. Retarget to net10.0 and update MSTest/test SDK packages. @
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three examples (Program.cs and tests) encoded the entire URL
http://example.com/resource?foo=bar with space#fragment, which percent-escapes the://,?and#that give a URL its structure and produces an unusable string. This reworks all three to encode only the query-string value and interpolate it into the URL, keeping the visible comparison between the classes (space as+vs%20). Also retargets both projects to net10.0 and updates the MSTest/test SDK packages.