String Split: fix cross-platform newline split; retarget net10.0 - #2108
Closed
vladimir-pecanac-main wants to merge 1 commit into
Closed
String Split: fix cross-platform newline split; retarget net10.0#2108vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets the SplitString sample to net10.0 and bumps its test packages to current stable (MSTest 4.3.3, Microsoft.NET.Test.Sdk 18.9.0, coverlet 10.0.1).
Fixes the new-lines example, which split a
\n-only input onEnvironment.NewLine(\r\non Windows) yet asserted five elements — so the test returned one element and failed on Windows. Normalising withReplaceLineEndings()before the split makes it deterministic on any OS. All 7 tests pass on net10.0.