Skip to content

HashSet in C#: modernize to .NET 10 and fix test defects #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladimir-pecanac-main wants to merge 1 commit into from
Closed

HashSet in C#: modernize to .NET 10 and fix test defects #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion collections-csharp/HashSetInCSharp/HashSetInCSharp/HashSetInCSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion collections-csharp/HashSetInCSharp/HashSetInCSharp/HashSetsInCSharpMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public HashSet<int> RandomInts(int size)
var rand = new Random();
var numbers = new HashSet<int>();

for (int i = 0; i < size; i++)
while (numbers.Count < size)
{
numbers.Add(rand.Next());
}
Expand Down
10 changes: 5 additions & 5 deletions collections-csharp/HashSetInCSharp/HashSetInCSharpTests/HashSetInCSharpTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
<PackageReference Include="MSTest.TestAdapter" Version="2.2.8" />
<PackageReference Include="MSTest.TestFramework" Version="2.2.8" />
<PackageReference Include="coverlet.collector" Version="3.1.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="MSTest.TestAdapter" Version="4.3.3" />
<PackageReference Include="MSTest.TestFramework" Version="4.3.3" />
<PackageReference Include="coverlet.collector" Version="10.0.1" />
</ItemGroup>

<ItemGroup>
Expand Down
22 changes: 11 additions & 11 deletions collections-csharp/HashSetInCSharp/HashSetInCSharpTests/HashSetInCSharpUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public HashSetInCSharpUnitTests()
public void GivenAHashSet_WhenNotEmpty_VerifyCountAndContains()
{
Assert.IsInstanceOfType(_languages, typeof(HashSet<string>));
Assert.AreEqual(_languages.Count(), 9);
Assert.AreEqual(9, _languages.Count);
Assert.IsTrue(_languages.Contains("C#"));
}

Expand All @@ -29,7 +29,7 @@ public void GivenAHashSet_WhenNotEmpty_VerifyHasNoDuplicates()
_languages.Add("C#");

Assert.IsInstanceOfType(_languages, typeof(HashSet<string>));
Assert.AreEqual(_languages.Count(), 9);
Assert.AreEqual(9, _languages.Count);
}

[TestMethod]
Expand All @@ -40,7 +40,7 @@ public void GivenAHashSet_WhenNotEmpty_VerifyAnElementRemoved()
var updatedLanguages = hashSet.RemoveElement(_languages, elementToRemove);

Assert.IsFalse(updatedLanguages.Contains(elementToRemove));
Assert.AreEqual(_languages.Count(), 8);
Assert.AreEqual(8, _languages.Count);
}

[TestMethod]
Expand All @@ -63,15 +63,15 @@ public void GivenAHashSet_WhenNotEmpty_VerifyNoOddElements()

Assert.IsTrue(checkValue);
Assert.IsFalse(oddNumbers.IsSubsetOf(numbers));
Assert.AreEqual(numbers.Union(oddNumbers).Count(), 100);
Assert.AreEqual(100, numbers.Union(oddNumbers).Count());
}

[TestMethod]
public void GivenAHashSet_WhenNotEmpty_VerifyAllElementsCleared()
{
_languages.Clear();

Assert.AreEqual(0, _languages.Count());
Assert.AreEqual(0, _languages.Count);
Assert.IsNull(_languages.FirstOrDefault());
}

Expand All @@ -83,7 +83,7 @@ public void GivenAHashSet_WhenNotEmpty_VerifyListPopulated()
var numbersList = hashSet.CreateList(numbers);

CollectionAssert.AllItemsAreInstancesOfType(numbersList, typeof(int));
Assert.AreEqual(numbersList.Count(), numbers.Count());
Assert.AreEqual(numbers.Count, numbersList.Count);
}

[TestMethod]
Expand All @@ -103,7 +103,7 @@ public void GivenAHashSet_WhenNotEmpty_VerifyUnionWithSuccessful()
var moreLanguages = new HashSet<string> { "Assembly", "Pascal", "HTML", "CSS", "PHP" };

_languages.UnionWith(moreLanguages);
Assert.AreEqual(_languages.Count(), 14);
Assert.AreEqual(14, _languages.Count);
}

[TestMethod]
Expand All @@ -113,7 +113,7 @@ public void GivenAHashSet_WhenNotEmpty_VerifyIntersectWithSuccessful()

_languages.IntersectWith(moreLanguages);

Assert.AreEqual(_languages.Count(), 5);
Assert.AreEqual(5, _languages.Count);
Assert.IsTrue(_languages.Contains("C"));
Assert.IsTrue(_languages.Contains("C++"));
Assert.IsTrue(_languages.Contains("C#"));
Expand All @@ -129,7 +129,7 @@ public void GivenAHashSet_WhenNotEmpty_ExceptWithSuccessful()

_languages.ExceptWith(moreLanguages);

Assert.AreEqual(_languages.Count(), 4);
Assert.AreEqual(4, _languages.Count);
Assert.IsTrue(_languages.Contains("TypeScript"));
Assert.IsTrue(_languages.Contains("Python"));
Assert.IsTrue(_languages.Contains("JavaScript"));
Expand All @@ -143,8 +143,8 @@ public void GivenAHashSet_WhenNotEmpty_VerifySymmetricExceptWithSuccessful()
var moreLanguages = new HashSet<string> { "Assembly", "Pascal", "HTML", "CSS", "PHP" };

_languages.SymmetricExceptWith(moreLanguages);
Assert.AreEqual(_languages.Count(), 14);

Assert.AreEqual(14, _languages.Count);
}

[TestMethod]
Expand Down
Loading