Skip to content

IntroductionToScrutorInDotNet: retarget net10.0, bump Scrutor to 7.0.0, add pitfalls tests #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimir-pecanac-main merged 1 commit into from
Aug 16, 2026
Merged

IntroductionToScrutorInDotNet: retarget net10.0, bump Scrutor to 7.0.0, add pitfalls tests #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...et/IntroductionToScrutorInDotNet.Customers/IntroductionToScrutorInDotNet.Customers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
8 changes: 4 additions & 4 deletions ...ctionToScrutorInDotNet/IntroductionToScrutorInDotNet/IntroductionToScrutorInDotNet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.7" />
<PackageReference Include="Scrutor" Version="4.2.2" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="10.0.11" />
<PackageReference Include="Scrutor" Version="7.0.0" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="10.2.3" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions ...cy-injection-tools/IntroductionToScrutorInDotNet/IntroductionToScrutorInDotNet/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
var builder = WebApplication.CreateBuilder(args);

builder.Services.Scan(selector => selector
.FromCallingAssembly()
.FromAssembliesOf(typeof(Program))
.AddClasses(
classSelector =>
classSelector.InNamespaces("IntroductionToScrutorInDotNet.Services.Implementations")
Expand All @@ -24,7 +24,7 @@
);

builder.Services.Scan(selector => selector
.FromCallingAssembly()
.FromAssembliesOf(typeof(Program))
.AddClasses(classSelector => classSelector.AssignableTo(typeof(IRepository<>)))
.UsingRegistrationStrategy(RegistrationStrategy.Skip)
.AsImplementedInterfaces());
Expand Down
85 changes: 85 additions & 0 deletions dependency-injection-tools/IntroductionToScrutorInDotNet/Tests/ScrutorPitfallsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
using IntroductionToScrutorInDotNet.Entities;
using IntroductionToScrutorInDotNet.Repositories;
using IntroductionToScrutorInDotNet.Repositories.Decorators;
using IntroductionToScrutorInDotNet.Repositories.Implementations;
using Microsoft.Extensions.DependencyInjection;
using Scrutor;

namespace Tests;

public class ScrutorPitfallsTests
{
private static ServiceCollection ScanRepositories(RegistrationStrategy? strategy = null)
{
var services = new ServiceCollection();
services.Scan(selector => selector
.FromAssembliesOf(typeof(UserRepository))
.AddClasses(classSelector => classSelector.AssignableTo(typeof(IRepository<>)))
.UsingRegistrationStrategy(strategy ?? RegistrationStrategy.Append)
.AsImplementedInterfaces());
return services;
}

[Fact]
public void GivenTwoScans_WhenAppending_ThenRegistrationIsDuplicated()
{
var services = ScanRepositories();
services.Scan(selector => selector
.FromAssembliesOf(typeof(UserRepository))
.AddClasses(classSelector => classSelector.AssignableTo(typeof(IRepository<>)))
.AsImplementedInterfaces());

var count = services.Count(descriptor => descriptor.ServiceType == typeof(IRepository<User>));

Assert.Equal(2, count);
}

[Fact]
public void GivenTwoScans_WhenUsingSkipStrategy_ThenRegistrationIsNotDuplicated()
{
var services = ScanRepositories(RegistrationStrategy.Skip);
services.Scan(selector => selector
.FromAssembliesOf(typeof(UserRepository))
.AddClasses(classSelector => classSelector.AssignableTo(typeof(IRepository<>)))
.UsingRegistrationStrategy(RegistrationStrategy.Skip)
.AsImplementedInterfaces());

var count = services.Count(descriptor => descriptor.ServiceType == typeof(IRepository<User>));

Assert.Equal(1, count);
}

[Fact]
public void GivenScannedRegistration_WhenLifetimeIsNotSpecified_ThenItIsTransient()
{
var services = ScanRepositories();

var descriptor = services.First(d => d.ServiceType == typeof(IRepository<User>));

Assert.Equal(ServiceLifetime.Transient, descriptor.Lifetime);
}

[Fact]
public void GivenNoPriorRegistration_WhenDecorating_ThenDecorationExceptionIsThrown()
{
var services = new ServiceCollection();

var exception = Assert.Throws<DecorationException>(() =>
services.Decorate<IRepository<User>, RepositoryLoggerDecorator<User>>());

Assert.Contains("Could not find any registered services", exception.Message);
}

[Fact]
public void GivenScannedRepository_WhenDecoratingTheOpenGeneric_ThenTheDecoratorResolves()
{
var services = ScanRepositories();

services.Decorate(typeof(IRepository<>), typeof(RepositoryLoggerDecorator<>));

var provider = services.BuildServiceProvider();
var resolved = provider.GetRequiredService<IRepository<User>>();

Assert.IsType<RepositoryLoggerDecorator<User>>(resolved);
}
}
13 changes: 7 additions & 6 deletions dependency-injection-tools/IntroductionToScrutorInDotNet/Tests/Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.9" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.11" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.1.2">
<PackageReference Include="coverlet.collector" Version="10.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Loading