fix: remove obsolete vendor-prefixed @keyframes and animation properties#549
Open
lekhmanrus wants to merge 1 commit intoCodeByZach:masterfrom
Open
Conversation
Remove `-webkit-`, `-moz-`, `-o-`, and `-ms-` prefixed `@keyframes`
rules and vendor-prefixed `animation` properties from all theme
templates and compiled theme files.
These vendor prefixes have been unnecessary since 2013+ as all modern
browsers support the unprefixed `@keyframes` and `animation` properties.
The vendor-prefixed `@keyframes` rules also cause build warnings in
applications using beasties (the critical CSS inliner), which fails to
parse percentage selectors (0%, 50%, 100%) inside vendor-prefixed
at-rules, producing:
"N rules skipped due to selector errors:
0% -> Unmatched selector: %"
Also removes duplicate `transform` properties inside unprefixed
`@keyframes` blocks in barber-shop, flash, and mac-osx themes.
Signed-off-by: Ruslan Lekhman <lekhman112@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
-webkit-,-moz-,-o-, and-ms-prefixed@keyframesrules and vendor-prefixedanimationproperties from all theme templates and compiled theme files.These vendor prefixes have been unnecessary since 2013+ as all modern browsers support the unprefixed
@keyframesandanimationproperties.The vendor-prefixed
@keyframesrules also cause build warnings in applications using beasties (the critical CSS inliner), which fails to parse percentage selectors (0%, 50%, 100%) inside vendor-prefixed at-rules, producing:"N rules skipped due to selector errors:
0% -> Unmatched selector: %"
Also removes duplicate
transformproperties inside unprefixed@keyframesblocks in barber-shop, flash, and mac-osx themes.