[SSF-232] Edit & Delete Donation Items Frontend#199
Open
jiang-h-y wants to merge 4 commits into
Open
Conversation
dburkhart07
requested changes
Jun 25, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
looking good so far! just some small things
| </Dialog.Title> | ||
| {currentUser?.role === Role.FOODMANUFACTURER && | ||
| donation.status === DonationStatus.AVAILABLE && | ||
| !hasAllocations && ( |
There was a problem hiding this comment.
correct me if im wrong, but i think these checks are redundant. a donation that is available means it has no allocations attached to it. i think we can remove this and hasAllocations entirely
Author
There was a problem hiding this comment.
In the db, there's a donation that is "available" but has allocations (screenshot). Without the check, the buttons render but don't allow edits/deletes.
Not sure if this donation is just for testing purposes, so if we don't think that this will be a general issue, I can remove this check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-232
📝 Description
For
/fm-donation-management:✔️ Verification
Tested cases for:
editDonationItemsbackend)Edit/Delete Buttons:
Editing View:
Delete Modal:
🏕️ (Optional) Future Work / Notes
what's the difference between "matched" and "available" donations?
i have an "available" donation with allocations, so no edit/delete buttons are displayed (screenshot).
if some "available" donations have edit/delete buttons (no allocations) and some don't have these buttons (because they have allocations), i think it's kind of confusing for the user since both donations are under "available." it would be helpful to put a note/visual indicator that "available" donations with allocations cannot be edited/deleted.