Skip to content

SSF-233 Pantry Confirm Delivery Email#194

Open
Juwang110 wants to merge 4 commits into
mainfrom
jw/ssf-233-pantry-confirm-delivery-email
Open

SSF-233 Pantry Confirm Delivery Email#194
Juwang110 wants to merge 4 commits into
mainfrom
jw/ssf-233-pantry-confirm-delivery-email

Conversation

@Juwang110

Copy link
Copy Markdown

ℹ️ Issue

Closes https://vidushimisra.atlassian.net/browse/SSF-233

📝 Description

I added a new Pantry Confirm Delivery Automated Email that reminds pantries to complete required actions on shipped orders. This is accompanied with a weekly cron job reminder.

✔️ Verification

Verified cron job and email sending works by having it send every 10 seconds.

🏕️ (Optional) Future Work / Notes

N/A

@jxuistrying jxuistrying self-requested a review June 13, 2026 21:02
@dburkhart07 dburkhart07 self-assigned this Jun 13, 2026
@Yurika-Kan Yurika-Kan requested a review from dburkhart07 June 20, 2026 23:02

@dburkhart07 dburkhart07 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things

Comment thread apps/backend/src/orders/order.service.ts Outdated
Comment thread apps/frontend/src/containers/pantryOrderManagement.tsx Outdated
Comment thread apps/backend/src/orders/order.service.spec.ts Outdated
Comment thread apps/backend/src/orders/order.service.spec.ts
@Juwang110 Juwang110 requested a review from dburkhart07 June 24, 2026 16:12

@dburkhart07 dburkhart07 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing but lgtm!!!!!!!!

toEmail: sentForSecondOrder.request.pantry.pantryUser.email,
subject: message.subject,
bodyHtml: message.bodyHTML,
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also confirm that the mockEmailsService is still called multiple times?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants