Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

Three things done here

  1. Use bufwriters when writing to disk for debug_symbols
  2. Serialize the whole perf-map content before saving in file for symbols
  3. End fifo's loop faster after program termination

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-1998-debug-symbol-collection-takes-a-very-long-time-in-walltime (f421432) with main (b8535fc)

Open in CodSpeed

@art049 art049 requested a review from not-matthias January 16, 2026 09:12
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I'd just replace the perf map writing logic with a BufWriter

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1998-debug-symbol-collection-takes-a-very-long-time-in-walltime branch from 5530881 to 689210e Compare January 16, 2026 15:12
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1998-debug-symbol-collection-takes-a-very-long-time-in-walltime branch from 689210e to f421432 Compare January 16, 2026 15:20
@GuillaumeLagrange GuillaumeLagrange merged commit f421432 into main Jan 16, 2026
13 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1998-debug-symbol-collection-takes-a-very-long-time-in-walltime branch January 16, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants