Skip to content

Build native code for both arm and x86 on release #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeLagrange merged 7 commits into from
Sep 26, 2025
Merged

Build native code for both arm and x86 on release #56

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32fa63e
ci: allow publishing alpha releases from tag
GuillaumeLagrange Aug 27, 2025
835fb02
chore(core): print error when failing to load native core
GuillaumeLagrange Sep 15, 2025
471a62f
ci(core): build artifacts for both x86 and arm64 during release
GuillaumeLagrange Sep 16, 2025
bb7c9d9
ci(core): run tests on arm as well
GuillaumeLagrange Sep 16, 2025
613c6a0
ci: fix deprecation warning about set-output
GuillaumeLagrange Sep 16, 2025
e8bd881
feat(core): throw when trying to call setupCore with no native core
GuillaumeLagrange Sep 26, 2025
69c156b
fix(core): fix tests failing after running `pnpm install`
GuillaumeLagrange Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ on:

jobs:
check:
runs-on: "ubuntu-latest"
strategy:
matrix:
os: ["ubuntu-latest", "codspeedhq-arm64-ubuntu-22.04"]
runs-on: ${{ matrix.os }}
steps:
- uses: "actions/checkout@v4"
with:
Expand All @@ -35,7 +38,7 @@ jobs:
# list the directories in ./examples and output them to a github action workflow variables as a JSON array
- run: |
examples=$(find ./examples -maxdepth 1 -mindepth 1 -type d -printf '%f\n' | jq -R -s -c 'split("\n") | map(select(length > 0))')
echo "::set-output name=examples::$examples"
echo "examples=$examples" >> $GITHUB_OUTPUT
id: list-examples

node-versions:
Expand Down
36 changes: 35 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,31 @@ permissions:
contents: write

jobs:
build-native-arm:
runs-on: codspeedhq-arm64-ubuntu-22.04

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
submodules: true
- uses: pnpm/action-setup@v2
- uses: actions/setup-node@v3
with:
cache: pnpm
node-version-file: .nvmrc
- run: pnpm install --frozen-lockfile --prefer-offline
- name: Build native code on ARM
run: pnpm moon core:build-native-addon
- name: Upload ARM prebuilds
uses: actions/upload-artifact@v4
with:
name: arm-prebuilds
path: packages/core/prebuilds

Comment thread
art049 marked this conversation as resolved.
build:
runs-on: ubuntu-latest
needs: build-native-arm

steps:
- uses: actions/checkout@v4
Expand All @@ -28,8 +51,19 @@ jobs:
- name: Build the libraries
run: pnpm moon run :build

- name: Download ARM prebuilds
uses: actions/download-artifact@v4
with:
name: arm-prebuilds
path: packages/core/prebuilds

- name: Publish the libraries
run: pnpm publish -r --access=public --no-git-checks
run: |
if [[ "${{ github.ref }}" == *"-alpha"* ]]; then
pnpm publish -r --access=public --no-git-checks --tag=alpha
else
pnpm publish -r --access=public --no-git-checks
fi
env:
NPM_CONFIG_PROVENANCE: true
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/native_core/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import path from "path";
import { logDebug } from "../utils";
import { InstrumentHooks } from "./instruments/hooks";
import { LinuxPerf } from "./linux_perf/linux_perf";
interface NativeCore {
Expand All @@ -21,6 +22,8 @@ try {
isBound: true,
};
} catch (e) {
logDebug("Failed to bind native core, instruments will not work.");
Comment thread
GuillaumeLagrange marked this conversation as resolved.
logDebug(e);
native_core = {
LinuxPerf: class LinuxPerf {
start() {
Expand Down