Skip to content

fix: remove fork(0) limitation from JMH runner #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 2 commits into from
Apr 7, 2026
+1 −13
Merged

fix: remove fork(0) limitation from JMH runner #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a213624
fix: remove fork(0) limitation from JMH runner
not-matthias Mar 31, 2026
4b7a767
fix: handle git worktrees in findGitRoot by checking for .git file or…
not-matthias Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jmh-fork/jmh-core/src/main/java/io/codspeed/BenchmarkUri.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static Path findGitRoot() {

Path current = Paths.get(System.getProperty("user.dir")).toAbsolutePath().normalize();
while (current != null) {
if (Files.isDirectory(current.resolve(".git"))) {
if (Files.exists(current.resolve(".git"))) {
cachedGitRoot = current;
return current;
}
Expand Down
12 changes: 0 additions & 12 deletions jmh-fork/jmh-core/src/main/java/org/openjdk/jmh/runner/Runner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ public class Runner extends BaseRunner {
private static final int TAIL_LINES_ON_ERROR = Integer.getInteger("jmh.tailLines", 20);
private static final String JMH_LOCK_FILE = System.getProperty("java.io.tmpdir") + "/jmh.lock";
private static final Boolean JMH_LOCK_IGNORE = Boolean.getBoolean("jmh.ignoreLock");
private static boolean codspeedForksWarningShown = false;

private final BenchmarkList list;
private int cpuCount;
Expand Down Expand Up @@ -478,17 +477,6 @@ private BenchmarkParams newBenchmarkParams(BenchmarkListEntry benchmark, ActionM
benchmark.getWarmupForks().orElse(
Defaults.WARMUP_FORKS));

// TODO(COD-1788): Remove this after process filtering is supported
if (InstrumentHooks.getInstance().isInstrumented() && !"1".equals(System.getenv("CODSPEED_JVM_ALLOW_FORKS"))) {
if ((forks > 0 || warmupForks > 0) && !codspeedForksWarningShown) {
out.println("# CodSpeed: forcing forks=0 to enable flamegraph support.");
out.println("# Set CODSPEED_JVM_ALLOW_FORKS=1 to disable this override.");
codspeedForksWarningShown = true;
}
forks = 0;
warmupForks = 0;
}

TimeUnit timeUnit = options.getTimeUnit().orElse(
benchmark.getTimeUnit().orElse(
Defaults.OUTPUT_TIMEUNIT));
Expand Down
Loading