chore: change group id of jmh fork#3
Conversation
COD-2400 Change group ID of JMH fork
What?We're currently reusing the However, if we want to publish our fork on MavenCentral, this won't work as they require a unique group id. This means we'll have to rename For gradle, they'll have to substitute the package: In Maven, we'd just have to replace the package name: How?
|
8122563 to
ec4fb25
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s forked JMH build/publish coordinates by moving it from org.openjdk.jmh to io.codspeed.jmh, and aligns the examples/composite-build wiring accordingly.
Changes:
- Change the JMH fork Maven/Gradle coordinates to
groupId=io.codspeed.jmhandversion=0.1.0. - Add Gradle composite-build dependency substitution so requests for
org.openjdk.jmh:*resolve to the includedjmh-forkprojects. - Update Maven and Gradle examples plus contributor docs to reflect the new coordinates/versioning.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Adds composite-build substitutions to map org.openjdk.jmh modules to the included jmh-fork projects. |
| jmh-fork/pom.xml | Updates parent POM groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-samples/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-generator-reflection/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-generator-bytecode/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-generator-asm/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-generator-annprocess/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-core/pom.xml | Updates parent groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-core-it/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-core-ct/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-core-benchmarks/pom.xml | Updates parent/dependency groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-archetypes/pom.xml | Updates parent groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-archetypes/jmh-scala-benchmark-archetype/src/main/resources/archetype-resources/pom.xml | Updates archetype resource dependencies groupId to io.codspeed.jmh. |
| jmh-fork/jmh-archetypes/jmh-scala-benchmark-archetype/pom.xml | Updates parent groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-archetypes/jmh-kotlin-benchmark-archetype/src/main/resources/archetype-resources/pom.xml | Updates archetype resource dependencies groupId to io.codspeed.jmh. |
| jmh-fork/jmh-archetypes/jmh-kotlin-benchmark-archetype/pom.xml | Updates parent groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-archetypes/jmh-java-benchmark-archetype/src/main/resources/archetype-resources/pom.xml | Updates archetype resource dependencies groupId to io.codspeed.jmh. |
| jmh-fork/jmh-archetypes/jmh-java-benchmark-archetype/pom.xml | Updates parent groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/jmh-archetypes/jmh-groovy-benchmark-archetype/src/main/resources/archetype-resources/pom.xml | Updates archetype resource dependencies groupId to io.codspeed.jmh. |
| jmh-fork/jmh-archetypes/jmh-groovy-benchmark-archetype/pom.xml | Updates parent groupId/version to io.codspeed.jmh:0.1.0. |
| jmh-fork/build.gradle.kts | Updates Gradle-published coordinates to io.codspeed.jmh:0.1.0. |
| examples/example-maven/pom.xml | Updates example dependencies and property to io.codspeed.jmh:0.1.0. |
| examples/example-gradle/build.gradle.kts | Updates the configured JMH version to 0.1.0. |
| CONTRIBUTING.md | Updates version-bump guidance to the new groupId/versioning scheme. |
| AGENTS.md | Updates publishing/versioning guidance to the new groupId/versioning scheme. |
Comments suppressed due to low confidence (2)
AGENTS.md:80
- AGENTS.md says to update the version reference in root
build.gradle.kts, but the rootbuild.gradle.ktscurrently has no JMH version reference. The version is set injmh-fork/build.gradle.ktsand in the example projects (e.g.examples/example-gradle/build.gradle.ktsandexamples/example-maven/pom.xml), so the docs should point to the right files.
Then update the version reference in root `build.gradle.kts`.
CONTRIBUTING.md:12
- CONTRIBUTING.md says to update the version reference in
build.gradle.kts, but there is no JMH version reference in the rootbuild.gradle.kts. This should referencejmh-fork/build.gradle.kts(and the example build files that pin the JMH version) to avoid contributors updating the wrong place.
This updates all pom.xml files in the multi-module project. After bumping, also update the version reference in build.gradle.kts.
</details>
---
💡 <a href="/CodSpeedHQ/codspeed-jvm/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
Merging this PR will degrade performance by 26.8%
Performance Changes
Comparing Footnotes
|
Prepares for MavenCentral publishing by using a unique group ID (`io.codspeed.jmh` instead of `org.openjdk.jmh`) and dropping the `-codspeed.N` version suffix. Refs: COD-2400
ec4fb25 to
c559c2b
Compare
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
lgtm, I have read everything very thoroughly
c559c2b
into
cod-2309-walltime-benchmarks-with-flamegraphs
No description provided.