feat: support pinning the codspeed-go-runner #176
Merged
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriencaccia
requested changes
Jan 23, 2026
Member
adriencaccia
left a comment
adriencaccia
left a comment
There was a problem hiding this comment.
As seen together, let's keep the installation of the go-runner inside codspeed
not-matthias
force-pushed
the
cod-1267-allow-go-runner-to-be-pinned
branch
from
6b8f638 to
11a039a
Compare
Member
|
@not-matthias can you rebase so we ensure the tests are passing? |
not-matthias
force-pushed
the
cod-1267-allow-go-runner-to-be-pinned
branch
2 times, most recently
from
1e5c627 to
d485ec8
Compare
Member
Author
|
I'll remove the memory tests for now and create a new issue to not block this PR (because it looks like we need some changes in the memtrack CLI to support some of the cmds) |
not-matthias
force-pushed
the
cod-1267-allow-go-runner-to-be-pinned
branch
from
d485ec8 to
6f9134f
Compare
adriencaccia
approved these changes
Jan 23, 2026
adriencaccia
requested changes
Jan 23, 2026
Member
adriencaccia
left a comment
adriencaccia
left a comment
There was a problem hiding this comment.
It should be documented in the readme as well
not-matthias
force-pushed
the
cod-1267-allow-go-runner-to-be-pinned
branch
from
6f9134f to
1d194bb
Compare
not-matthias
force-pushed
the
cod-1267-allow-go-runner-to-be-pinned
branch
from
1d194bb to
dfb7340
Compare
Member
Author
|
Good catch. Also updated the description to match the one in the runner |
adriencaccia
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the failing tests are only due to memory which doesn't support
allow-emptyat the moment, was fixed in CodSpeedHQ/codspeed#205)Depends on
CodSpeedHQ/codspeed#213#178