Fix bug of git shallow cloning and better performance when cloning#122
Open
xuzhongping wants to merge 1 commit intoCocoaPods:masterfrom
Open
Fix bug of git shallow cloning and better performance when cloning#122xuzhongping wants to merge 1 commit intoCocoaPods:masterfrom
xuzhongping wants to merge 1 commit intoCocoaPods:masterfrom
Conversation
1 task
60f5691 to
fbaa675
Compare
d25112f to
b897624
Compare
b897624 to
ac0891e
Compare
|
Can we please get this merged? Currently, for every With this fix we only have to download 15 MB and it's over 30 times faster! cc @dnkoutso |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #106
description
It should be noted that this will break the caching mechanism (for the old downloaded cache) when using branch when git downloads in the external pod in cocoapods, because I will keep the parameter ‘branch’ after preprocessing options.
If this modification is approved, I would like to go to the cocoapods gem to optimize git's caching strategy.
other
Yes, mainly to fix the same problem, but there are some bugs in that PR, I tried to inform the author, but didn't get a follow-up, I think I can provide a more complete fix.
Yes, this PR does more than one bug fix, there are actually three, but there are some dependencies between them, and it would be very troublesome to deal with them separately, so I merged them together,and they all come with adequate testing,you can see my intent in the spec file.