fix: Update StackPanel Spacing styles in WpfUiCustom.xaml theme #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem The WpfUiCustom.xaml theme file contained 3 StackPanel styles that used Property="Spacing", which doesn't exist in WPF StackPanel: - StandardSpacing (Spacing=12) - CompactSpacing (Spacing=8) - WideSpacing (Spacing=16) These styles were causing XAML build errors at lines 68, 72, and 76. ## Solution 1. Added xmlns:helpers namespace to ResourceDictionary with assembly reference 2. Updated all 3 style definitions to use helpers:StackPanelHelper.Spacing attached property instead of Property="Spacing" ## Files Changed - Themes/WpfUiCustom.xaml ## Result All StackPanel spacing styles now use the WPF-compatible StackPanelHelper attached property, maintaining the same spacing values and functionality.
Co0ob1iee
deleted the
claude/cleanup-logs-project-01CgeLKK4Nw2cK3rDJdLF88m
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The WpfUiCustom.xaml theme file contained 3 StackPanel styles that used Property="Spacing", which doesn't exist in WPF StackPanel:
These styles were causing XAML build errors at lines 68, 72, and 76.
Solution
Files Changed
Result
All StackPanel spacing styles now use the WPF-compatible StackPanelHelper attached property, maintaining the same spacing values and functionality.