fix: Replace StackPanel.Spacing with StackPanelHelper for WPF compati… #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility ## Problem WPF StackPanel does not support the Spacing property (this is a WinUI/UWP feature). Build errors occurred in 9 XAML files: - Views/Dialogs/SaveScreenshotDialog.xaml - Views/Windows/ScreenshotEditorWindow.xaml - Views/Windows/ScreenshotHistoryWindow.xaml - Views/Windows/SettingsWindow.xaml - Views/Windows/TextInputWindow.xaml - Views/Windows/UpdateNotificationWindow.xaml - Views/Windows/UpdateProgressWindow.xaml - Views/Windows/UpdateWindow.xaml - Views/Windows/VideoCaptureWindow.xaml Additional error: UseSnapLayout property in SettingsWindow.xaml TitleBar ## Solution 1. Created StackPanelHelper.cs with Spacing attached property - Provides WPF-compatible spacing functionality - Automatically applies margins to child elements - Supports both horizontal and vertical orientations 2. Updated all 9 XAML files: - Added xmlns:helpers namespace - Replaced Spacing="X" with helpers:StackPanelHelper.Spacing="X" - Removed unsupported UseSnapLayout property ## Files Changed - New: Helpers/StackPanelHelper.cs (76 lines) - Modified: 9 XAML files with Spacing property fixes ## Testing - Verified no remaining StackPanel.Spacing references - All XAML errors resolved - Ready for build
Co0ob1iee
deleted the
claude/cleanup-logs-project-01CgeLKK4Nw2cK3rDJdLF88m
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bility
Problem
WPF StackPanel does not support the Spacing property (this is a WinUI/UWP feature). Build errors occurred in 9 XAML files:
Additional error: UseSnapLayout property in SettingsWindow.xaml TitleBar
Solution
Created StackPanelHelper.cs with Spacing attached property
Updated all 9 XAML files:
Files Changed
Testing