fix: handle concurrent node connection establishment - #1875
Open
0utplay wants to merge 1 commit into
Open
Conversation
0utplay
added
v: 4.X
There was a problem hiding this comment.
Pull request overview
This PR fixes a startup-time concurrency issue during parallel node connection establishment by removing shared mutable state updates from asynchronous completion callbacks and instead aggregating connection outcomes after all connection attempts finish.
Changes:
- Replace
Phaser+ concurrently-mutatedLinkedListapproach with aCompletableFuture.allOf(...)aggregation. - Collect per-node “wait until available” suppliers only after all connection futures complete, avoiding concurrent writes/removals.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
0utplay
marked this pull request as ready for review
August 10, 2026 11:54
derklaro
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When multiple nodes are configured and one of them starts and tries to connect to the other ones (in parallel) a concurrent write on the existing LinkedList would cause issues in the second step where unavailable nodes would get removed.
Modification
Replaced the phaser implementation with a stream and a future wrapping all connection futures
Result
No more exceptions on startup
Other context
Fixes https://discord.com/channels/325362837184577536/818777626663321671/1535395256055627889