Define a generalized function for display_submission_*#253
Open
hkmatsumoto wants to merge 4 commits intoCloud-CV:masterfrom
hkmatsumoto:take-in-util-function-to-command-function
Open
Define a generalized function for display_submission_*#253hkmatsumoto wants to merge 4 commits intoCloud-CV:masterfrom hkmatsumoto:take-in-util-function-to-command-function
hkmatsumoto wants to merge 4 commits intoCloud-CV:masterfrom
hkmatsumoto:take-in-util-function-to-command-function
Conversation
|
@takitsuse I think what @vkartik97 meant was using a single submission_result util function to extract all useful content. Adding a new argument in the function i.e. |
Contributor
Author
|
Okay, is @pushkalkatara's comment what you ment @vkartik97? |
Member
Yes 💯 |
Contributor
Author
|
Defined a generalized function as @pushkalkatara's proposal. |
krtkvrm
reviewed
Jan 12, 2020
Member
|
Can you please fix the travis build? |
Contributor
Author
|
@vkartik97 Fixed 👍 |
Contributor
Author
|
Should I merge this change to #252? |
krtkvrm
reviewed
Jan 12, 2020
krtkvrm
reviewed
Jan 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
display_submission_*, since those functions will be very similar to each other.