Skip to content

[clent-v2] Support Reading JSONEachRow #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chernser wants to merge 30 commits into
base: main
Choose a base branch
from

covered getters by index

ed814b1
Select commit
Loading
Failed to load commit list.
Draft

[clent-v2] Support Reading JSONEachRow #2823

covered getters by index
ed814b1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 28, 2026 in 1m 6s

Quality Gate failed

Failed conditions
14.9% Coverage on New Code (required ≥ 80%)
15.1% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 214 in client-v2/src/test/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReaderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZyfljB2pEMc24Nit&open=AZ5DZyfljB2pEMc24Nit&pullRequest=2823

Check warning on line 110 in client-v2/src/test/java/com/clickhouse/client/api/data_formats/AbstractJSONEachRowFormatReaderTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClickHouseNode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygKjB2pEMc24Niu&open=AZ5DZygKjB2pEMc24Niu&pullRequest=2823

Check warning on line 549 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty array instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5M5PRvMoFideS-hv5e&open=AZ5M5PRvMoFideS-hv5e&pullRequest=2823

Check warning on line 49 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/GsonJsonParserFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty map instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygRjB2pEMc24Nix&open=AZ5DZygRjB2pEMc24Nix&pullRequest=2823

Check warning on line 59 in client-v2/src/test/java/com/clickhouse/client/api/data_formats/AbstractJSONEachRowFormatReaderTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClickHouseNode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5tGbVG6rv_DrW9ysdn&open=AZ5tGbVG6rv_DrW9ysdn&pullRequest=2823

Check warning on line 244 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5tGbWr6rv_DrW9ysdp&open=AZ5tGbWr6rv_DrW9ysdp&pullRequest=2823

Check failure on line 190 in jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use try-with-resources or close this "JSONEachRowFormatReader" in a "finally" clause. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZyiEjB2pEMc24Ni5&open=AZ5DZyiEjB2pEMc24Ni5&pullRequest=2823

Check warning on line 104 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygnjB2pEMc24Ni2&open=AZ5DZygnjB2pEMc24Ni2&pullRequest=2823

Check failure on line 190 in client-v2/src/test/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReaderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZyfljB2pEMc24Nis&open=AZ5DZyfljB2pEMc24Nis&pullRequest=2823

Check warning on line 56 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygnjB2pEMc24Ni1&open=AZ5DZygnjB2pEMc24Ni1&pullRequest=2823

Check warning on line 292 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty array instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5tGbWr6rv_DrW9ysdq&open=AZ5tGbWr6rv_DrW9ysdq&pullRequest=2823

Check failure on line 192 in jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use try-with-resources or close this "ClickHouseBinaryFormatReader" in a "finally" clause. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZyiEjB2pEMc24Ni6&open=AZ5DZyiEjB2pEMc24Ni6&pullRequest=2823

Check warning on line 41 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JacksonJsonParserFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty map instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygYjB2pEMc24Niz&open=AZ5DZygYjB2pEMc24Niz&pullRequest=2823

Check warning on line 89 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty map instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5MgfXdOfcB09p3JPSM&open=AZ5MgfXdOfcB09p3JPSM&pullRequest=2823

Check warning on line 180 in clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseDataType.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this member "protected". 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5tGbUT6rv_DrW9ysdm&open=AZ5tGbUT6rv_DrW9ysdm&pullRequest=2823

Check warning on line 46 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Iterate over the "entrySet" instead of the "keySet". 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5MgfXdOfcB09p3JPSL&open=AZ5MgfXdOfcB09p3JPSL&pullRequest=2823

Check warning on line 16 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JsonParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygejB2pEMc24Ni0&open=AZ5DZygejB2pEMc24Ni0&pullRequest=2823

Check warning on line 316 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/JSONEachRowFormatReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5tGbWr6rv_DrW9ysdr&open=AZ5tGbWr6rv_DrW9ysdr&pullRequest=2823

Check warning on line 98 in client-v2/src/test/java/com/clickhouse/client/api/data_formats/AbstractJSONEachRowFormatReaderTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClickHouseNode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5tGbVG6rv_DrW9ysdo&open=AZ5tGbVG6rv_DrW9ysdo&pullRequest=2823

Check warning on line 52 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/GsonJsonParserFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty map instead of null. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ5DZygRjB2pEMc24Niy&open=AZ5DZygRjB2pEMc24Niy&pullRequest=2823
View more details on SonarQubeCloud