Skip to content

Fix CI #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slabko merged 1 commit into from
Feb 27, 2026
Merged

Fix CI #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ on:
env:
BUILD_TYPE: Release
CLICKHOUSE_SERVER_IMAGE: "clickhouse/clickhouse-server:22.3"
CLICKHOUSE_SECURE_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
CLICKHOUSE_SECURE_USER: default
CLICKHOUSE_SECURE_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
Comment on lines +19 to +21
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow runs on pull_request, but these values are sourced from repository secrets. For PRs from forks, secrets.* will be empty, which may cause the TLS integration tests (e.g., ut/ssl_ut.cpp) to connect with empty host/password and fail. Consider providing a fallback to the public demo endpoint/creds or gating remote TLS tests to trusted contexts only.

Suggested change
CLICKHOUSE_SECURE_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
CLICKHOUSE_SECURE_USER: default
CLICKHOUSE_SECURE_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
CLICKHOUSE_SECURE_HOST: >-
${{ (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork)
&& 'play.clickhouse.com:9440'
|| secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
CLICKHOUSE_SECURE_USER: default
CLICKHOUSE_SECURE_PASSWORD: >-
${{ (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork)
&& 'play_password'
|| secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}

Copilot uses AI. Check for mistakes.

jobs:
build:
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@ on:

env:
BUILD_TYPE: Release
CLICKHOUSE_USER: clickhouse_cpp_cicd
CLICKHOUSE_PASSWORD: clickhouse_cpp_cicd
CLICKHOUSE_USER: default
CLICKHOUSE_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
CLICKHOUSE_SECURE_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
CLICKHOUSE_SECURE_PORT: 9440
CLICKHOUSE_SECURE_USER: default
Comment on lines +17 to +21
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow runs on pull_request, but these values are sourced from repository secrets. For PRs from forks, secrets.* will be empty, which can break both the non-TLS and TLS integration test suites. Consider providing defaults (e.g., the existing public demo endpoint/creds) or skipping the remote-integration portions unless the PR comes from the same repository.

Copilot uses AI. Check for mistakes.
CLICKHOUSE_SECURE_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
CLICKHOUSE_SECURE_DB: default

jobs:
build:
Expand Down Expand Up @@ -43,6 +48,9 @@ jobs:
- name: Install dependencies
run: brew install cmake ${{matrix.SSL_INSTALL}}

- name: Print OpenSSL paths
run: openssl version -d

- name: Configure CMake
run: |
cmake \
Expand All @@ -66,7 +74,7 @@ jobs:
run: |
wget https://github.com/filimonov/go-tlsoffloader/releases/download/v0.1.2/go-tlsoffloader_0.1.2_Darwin_x86_64.tar.gz
tar -xvzf go-tlsoffloader_0.1.2_Darwin_x86_64.tar.gz
./go-tlsoffloader -l localhost:9000 -b github.demo.trial.altinity.cloud:9440 &
./go-tlsoffloader -l localhost:9000 -b ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}:9440 &
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT is empty (e.g., on fork PRs), this will pass an invalid backend (:9440) and the proxy may exit immediately while the step still succeeds due to running it in the background. Add an explicit check for an empty host (or use a default) so failures are immediate and actionable.

Copilot uses AI. Check for mistakes.

- name: Test
working-directory: ${{github.workspace}}/build/ut
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows_mingw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ on:

env:
BUILD_TYPE: Release
CLICKHOUSE_USER: clickhouse_cpp_cicd
CLICKHOUSE_PASSWORD: clickhouse_cpp_cicd
CLICKHOUSE_USER: default
CLICKHOUSE_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
Comment on lines +18 to +19
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These env values come from repository secrets, but this workflow runs on pull_request. For PRs from forks, secrets.* will be empty, which can make the integration tests fail (e.g., auth failures) in a non-obvious way. Consider adding a safe fallback (e.g., demo credentials) or gating the jobs/steps that require secrets to only run when github.event.pull_request.head.repo.full_name == github.repository.

Copilot uses AI. Check for mistakes.

#
# CLICKHOUSE_HOST: localhost
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
run: |
wget https://github.com/filimonov/go-tlsoffloader/releases/download/v0.1.2/go-tlsoffloader_0.1.2_Windows_x86_64.tar.gz
tar -xvzf go-tlsoffloader_0.1.2_Windows_x86_64.tar.gz
./go-tlsoffloader.exe -l localhost:9000 -b github.demo.trial.altinity.cloud:9440 &
./go-tlsoffloader.exe -l localhost:9000 -b ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}:9440 &
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT is empty (e.g., on fork PRs where secrets aren’t provided), this command will end up passing -b :9440 and likely fail silently in the background, causing confusing downstream test failures. Consider reading the host from an env var with a default, and/or add a check that fails early when the host is empty.

Copilot uses AI. Check for mistakes.

- name: Test
env:
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/windows_msvc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ on:

env:
BUILD_TYPE: Release
CLICKHOUSE_USER: clickhouse_cpp_cicd
CLICKHOUSE_PASSWORD: clickhouse_cpp_cicd
#
CLICKHOUSE_USER: default
CLICKHOUSE_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
Comment on lines +18 to +19
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These env values come from repository secrets, but this workflow runs on pull_request. For PRs from forks, secrets.* will be empty, which can make the integration tests fail (e.g., auth failures) in a non-obvious way. Consider adding a safe fallback (e.g., demo credentials) or gating the jobs/steps that require secrets to only run when github.event.pull_request.head.repo.full_name == github.repository.

Copilot uses AI. Check for mistakes.
# CLICKHOUSE_HOST: localhost
# CLICKHOUSE_PORT: 9000
# CLICKHOUSE_USER: default
Expand Down Expand Up @@ -62,7 +61,7 @@ jobs:
choco install wget
wget https://github.com/filimonov/go-tlsoffloader/releases/download/v0.1.2/go-tlsoffloader_0.1.2_Windows_x86_64.tar.gz
tar -xvzf go-tlsoffloader_0.1.2_Windows_x86_64.tar.gz
./go-tlsoffloader.exe -l localhost:9000 -b github.demo.trial.altinity.cloud:9440 &
./go-tlsoffloader.exe -l localhost:9000 -b ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}:9440 &
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT is empty (e.g., on fork PRs where secrets aren’t provided), this command will end up passing -b :9440 and likely fail silently in the background, causing confusing downstream test failures. Consider reading the host from an env var with a default, and/or add a check that fails early when the host is empty.

Copilot uses AI. Check for mistakes.

- name: Test
env:
Expand Down
Loading